From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
kaber@trash.net
Subject: Re: [NETFILTER] fix conntrack event cache deadlock
Date: Fri, 23 Sep 2005 11:25:52 +0200 [thread overview]
Message-ID: <20050923092552.GC731@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20050922.234724.110942393.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On Thu, Sep 22, 2005 at 11:47:24PM -0700, David S. Miller wrote:
> From: Harald Welte <laforge@netfilter.org>
> Date: Thu, 22 Sep 2005 16:35:15 +0200
>
> > [NETFILTER] Fix conntrack event cache deadlock/oops
>
> Applied. I hope that doing the event cache call outside
> the lock is safe? It was not depending upon that protection
> in any way was it?
no, not at all. It was a mistake to call it within the locked section.
The call was erroneously placed there, because it fitted there without
reorganizing the code flow.
--
- Harald Welte <laforge@netfilter.org> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2005-09-23 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 14:35 [NETFILTER] fix conntrack event cache deadlock Harald Welte
2005-09-23 6:47 ` David S. Miller
2005-09-23 9:25 ` Harald Welte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050923092552.GC731@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox