From: "David S. Miller" <davem@davemloft.net>
To: kuznet@ms2.inr.ac.ru
Cc: greearb@candelatech.com, ja@ssi.bg, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: Debugging neighbour.c: timers
Date: Mon, 26 Sep 2005 17:48:05 -0700 (PDT) [thread overview]
Message-ID: <20050926.174805.31061388.davem@davemloft.net> (raw)
In-Reply-To: <20050927003845.GA8273@ms2.inr.ac.ru>
From: "A.N.Kuznetsov" <kuznet@ms2.inr.ac.ru>
Date: Tue, 27 Sep 2005 04:38:45 +0400
> Actually, when this code was written, add_timer() behaved differently,
> double add_timer() was prohibited and it printked
> "bug: kernel timer added twice at...".
Yes, it calls __mod_timer() now. That's quite bad and
the debugging check should be re-added I think.
Is there some reason why we want add_timer() to behave like
__mod_timer(timer, timer->expires)? I can't see any...
So perhaps we should add the simple BUG_ON(timer->pending) check to
include/linux/timer.h:add_timer()
add_timer_on() does this check btw....
parent reply other threads:[~2005-09-27 0:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20050927003845.GA8273@ms2.inr.ac.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050926.174805.31061388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=greearb@candelatech.com \
--cc=ja@ssi.bg \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox