From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Roger Tsang <roger.tsang@gmail.com>,
Luca Maranzano <liuk001@gmail.com>,
"LinuxVirtualServer.org users mailing list."
<lvs-users@LinuxVirtualServer.org>,
Dave Miller <davem@davemloft.net>,
Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
netdev@oss.sgi.com
Subject: Re: ipvs_syncmaster brings cpu to 100%
Date: Sun, 25 Sep 2005 21:34:00 -0700 [thread overview]
Message-ID: <20050926043400.GD5079@us.ibm.com> (raw)
In-Reply-To: <20050926032807.GI18357@verge.net.au>
On 26.09.2005 [12:28:08 +0900], Horms wrote:
> On Fri, Sep 23, 2005 at 11:15:31AM -0400, Roger Tsang wrote:
> > As I've said before in this thread, you might want to try changing all the
> > ssleep() calls to schedule_timeout().
> >
> > Roger
> >
> >
> > On 9/22/05, Luca Maranzano <liuk001@gmail.com> wrote:
> > >
> > > Hello all,
> > >
> > > here again trying to discover the reason ot the CPU hog for
> > > ipvs_sync{master,backup}.
> > >
> > > I've digged in the sources for ip_vs_sync.c and the main differences
> > > between kernel 2.6.8 and 2.6.12 is the use of ssleep() instead of
> > > schedule_timeout().
> > >
> > > The oddity I've seen is that in the header of both files, the version
> > > is always like this:
> > >
> > > * Version: $Id: ip_vs_sync.c,v 1.13 2003/06/08 09:31:19 wensong Exp $
> > > *
> > > * Authors: Wensong Zhang <wensong@linuxvirtualserver.org>
> > >
> > > Is Wensong still the maintainer for this code?
>
> Yes, although he is kind of quiet.
>
> > > Furthermore, if I make an "rgrep" in the source tree of kernel 2.6.12
> > > the function schedule_timeout() is more used than the ssleep() (517
> > > occurrencies vs. 43), so why in ip_vs_sync.c there was this change?
> > >
> > > The other oddity is that Horms reported on this list that on non Xeon
> > > CPU the same version of kernel of mine does not present the problem.
> > >
> > > I'm getting crazy :-)
>
> I've prepared a patch, which reverts the change which was introduced
> by Nishanth Aravamudan in February.
Was the 100% cpu utilization only occurring on Xeon processors?
Care to try to use msleep_interruptible() instead of ssleep(), as
opposed to schedule_timeout()?
In your patch, you do not need to set the state back to TASK_RUNNING,
btw.
Thanks,
Nish
next prev parent reply other threads:[~2005-09-26 4:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <68559cef050908090657fc2599@mail.gmail.com>
[not found] ` <498263350509081605956a771@mail.gmail.com>
[not found] ` <68559cef05092207022f1f0df4@mail.gmail.com>
[not found] ` <498263350509230815eb08a73@mail.gmail.com>
2005-09-26 3:28 ` ipvs_syncmaster brings cpu to 100% Horms
[not found] ` <20050926032807.GI18357@verge.net.au>
2005-09-26 4:34 ` Nishanth Aravamudan [this message]
2005-09-26 8:05 ` Horms
[not found] ` <20050926080508.GF11027@verge.net.au>
2005-09-26 8:12 ` Horms
[not found] ` <20050926081229.GA23755@verge.net.au>
2005-09-26 13:11 ` Nishanth Aravamudan
2005-09-26 13:52 ` Luca Maranzano
[not found] ` <68559cef05092606521cc13f9a@mail.gmail.com>
2005-09-26 14:21 ` Nishanth Aravamudan
2005-09-26 14:44 ` Luca Maranzano
2005-09-26 17:51 ` Nishanth Aravamudan
2005-09-28 2:23 ` Horms
2005-09-28 13:26 ` Nishanth Aravamudan
2005-09-29 7:00 ` Julian Anastasov
2005-09-30 15:59 ` Luca Maranzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050926043400.GD5079@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=liuk001@gmail.com \
--cc=lvs-users@LinuxVirtualServer.org \
--cc=netdev@oss.sgi.com \
--cc=roger.tsang@gmail.com \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).