From: Olaf Hering <olh@suse.de>
To: netdev@vger.kernel.org, linuxppc64-dev@ozlabs.org
Subject: pcnet32 does not use the PROM address on powerpc
Date: Sat, 8 Oct 2005 12:47:25 +0200 [thread overview]
Message-ID: <20051008104725.GA10248@suse.de> (raw)
Does anyone remember why ppc is handled special in pcnet32_probe1()?
It as added to Linus tree around 2.6.14, I dont find relevant patches in
our bugzilla. It was likely added during early ppc64 bringup.
google doesnt know the patch submitter, perhaps jgarzik has some old
records from around 2000/2001?
I have a 44p 270, which gets all 0xFF as MAC address if I power if off
and on again. Further reboots do not fix it.
But it does get the correct one if I boot into SMS and do a netboot,
further reboots will always get the correct MAC address
I think these 0xFF happen also on other systems, I have seen them on B50
as well. We should just remove the #ifdef.
....
if (memcmp(promaddr, dev->dev_addr, 6)
|| !is_valid_ether_addr(dev->dev_addr)) {
#ifndef __powerpc__
if (is_valid_ether_addr(promaddr)) {
#else
if (!is_valid_ether_addr(dev->dev_addr)
&& is_valid_ether_addr(promaddr)) {
#endif
if (pcnet32_debug & NETIF_MSG_PROBE) {
printk(" warning: CSR address invalid,\n");
printk(KERN_INFO " using instead PROM address of");
}
memcpy(dev->dev_addr, promaddr, 6);
}
}
....
--
short story of a lazy sysadmin:
alias appserv=wotan
next reply other threads:[~2005-10-08 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-08 10:47 Olaf Hering [this message]
2005-10-08 12:03 ` pcnet32 does not use the PROM address on powerpc Olaf Hering
2005-10-10 14:23 ` [PATCH] " Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051008104725.GA10248@suse.de \
--to=olh@suse.de \
--cc=linuxppc64-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).