[ANNOUNCE] iproute2 version (050929)

[ANNOUNCE] iproute2 version (050929)

[Stephen Hemminger]

There is an new minor update to iproute2 utilities available:
	http://developer.osdl.org/dev/iproute2/download/iproute2-050929.tar.gz

Also, this (and future) releases are now signed, for key info read:
	http://developer.osdl.org/dev/iproute2/signature.html

[Stephen Hemminger]
	Fix uninitialized memory and leaks
	Add -batch option to ip.
	Update to 2.6.14 headers

[Arnaldo]
        Integrate support for DCCP into 'ss'

[Mike Frysinger]
	Fix build issues with netem tables (parallel make and HOSTCC)

[Eric Dumazet]
	Fix lnstat : First column should not be summed


-- 
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger

Re: [ANNOUNCE] iproute2 version (050929)

[Stephen Hemminger]

On Sat, 1 Oct 2005 23:34:25 +0200 (CEST)
Krzysztof Oledzki <olel@ans.pl> wrote:

> 
> 
> On Fri, 30 Sep 2005, Stephen Hemminger wrote:
> 
> > There is an new minor update to iproute2 utilities available:
> > 	http://developer.osdl.org/dev/iproute2/download/iproute2-050929.tar.gz
> 
> 
> It hangs on "ip rule flush". Tested on 2.6.13.2.
> 
> 
> Best regards,
> 
> 
>  			Krzysztof Olędzki

Fixed by this patch (in next release)

==========

When assigning an ip address to an ethernet adapter, the newest 
(050929) version of 'ip addr' hangs while older versions worked. 
The problem was traced to be a removed initialisation. The patch 
below corrects this problem.

Regards,
Jerome Borsboom

--- iproute2-050929/lib/libnetlink.c    2005-09-21 21:33:18.000000000 +0200
+++ iproute2-050929/lib/libnetlink.c    2005-10-04 13:42:30.000000000 +0200
@@ -235,7 +235,10 @@
        unsigned seq;
        struct nlmsghdr *h;
        struct sockaddr_nl nladdr;
-       struct iovec iov;
+       struct iovec iov = {
+               .iov_base = (void*)n,
+               .iov_len = n->nlmsg_len
+       };
        struct msghdr msg = {
                .msg_name = &nladdr,
                .msg_namelen = sizeof(nladdr),

-- 
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger

Re: [ANNOUNCE] iproute2 version (050929)

[Stephen Hemminger]

On Mon, 10 Oct 2005 12:34:51 +0200 (CEST)
Krzysztof Oledzki <olel@ans.pl> wrote:

> 
> 
> On Wed, 5 Oct 2005, Stephen Hemminger wrote:
> 
> > On Sat, 1 Oct 2005 23:34:25 +0200 (CEST)
> > Krzysztof Oledzki <olel@ans.pl> wrote:
> >
> >>
> >>
> >> On Fri, 30 Sep 2005, Stephen Hemminger wrote:
> >>
> >>> There is an new minor update to iproute2 utilities available:
> >>> 	http://developer.osdl.org/dev/iproute2/download/iproute2-050929.tar.gz
> >>
> >>
> >> It hangs on "ip rule flush". Tested on 2.6.13.2.
> >>
> >>
> >> Best regards,
> >>
> >>
> >>  			Krzysztof Olędzki
> >
> > Fixed by this patch (in next release)
> 
> Not sure... Just checked iproute2-ss051007 and it still hangs on "ip rule 
> flush" with ~100% cpu load.
> 

Are you running as root? If not it will loop forever.

Re: [ANNOUNCE] iproute2 version (050929)

[Stephen Hemminger]

On Mon, 10 Oct 2005 16:37:00 -0400
jamal <hadi@cyberus.ca> wrote:

> On Mon, 2005-10-10 at 22:08 +0200, Krzysztof Oledzki wrote:
> > 
> 
> > >
> > > Why are you trying to flush those tables?
> > To install a new set of rules.
> > 
> 
> 
> flush should kill everything if i am not mistaken. 
> Are you replacing the main table etc as well?
> 
> > > Try to downgrade the kernel and see what happens - go as far as 2.6.12
> > But why? It works with older (ss050330) version of iproute2 even on 
> > 2.6.13.3.
> > 
> 
> Ok, sorry i wasnt aware of that. Try the attached patch.
> 
> cheers,
> jamal

Look like the -batch code that keeps the RTNL handle open was
breaking this.  The patch shows the general idea, but it still has
problems because I think it would still not work if used in
-batch situation.

-- 
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger

Re: [ANNOUNCE] iproute2 version (050929)

[Stephen Hemminger]

On Mon, 10 Oct 2005 20:31:31 -0400
jamal <hadi@cyberus.ca> wrote:

> On Mon, 2005-10-10 at 16:16 -0700, Stephen Hemminger wrote:
> 
> > Look like the -batch code that keeps the RTNL handle open was
> > breaking this.  The patch shows the general idea, but it still has
> > problems because I think it would still not work if used in
> > -batch situation.
> 
> I see what you mean.
> You definitely need at least one extra socket for deleting
> in the flush_rule(). Something like the attached, untested,
> uncompiled.
> 
> 
> Krzysztof, if you have time please try the attached patch?
> 
> cheers,
> jamal

applied to iproute2 cvs

-- 
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger