From: Stephen Hemminger <shemminger@osdl.org>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Manfred Spraul <manfred@colorfullife.com>,
Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH 2/2] forcedeth: scatter gather and segmentation offload support
Date: Mon, 24 Oct 2005 14:21:28 -0700 [thread overview]
Message-ID: <20051024142128.3193bc22@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <435D1047.2070401@nvidia.com>
On Mon, 24 Oct 2005 12:48:07 -0400
Ayaz Abdulla <aabdulla@nvidia.com> wrote:
> Jeff,
>
> I made the changes you requested. Here is the new patch.
>
> Thanks,
> Ayaz
>
> Signed-off-By: Ayaz Abdulla <aabdulla@nvidia.com>
>
There are really three patches in here.
1. Use netdev_priv (trivial)
2. scatter/gather support
3. TSO support
Why do you set the fragments up in reverse order? Going backwards is
usually slow on most code.
The kernel coding style is to use lower case in local variable names (Flags)
and structure elements (PacketBuffer, FlagLen).
--
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger
next prev parent reply other threads:[~2005-10-24 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 14:01 [PATCH 2/2] forcedeth: scatter gather and segmentation offload support Manfred Spraul
2005-10-21 21:23 ` Jeff Garzik
2005-10-24 16:48 ` Ayaz Abdulla
2005-10-24 18:00 ` Stephen Hemminger
2005-10-24 17:05 ` Ayaz Abdulla
2005-10-26 4:53 ` Jeff Garzik
2005-10-24 21:21 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-25 21:15 Ayaz Abdulla
2005-10-25 21:59 ` Francois Romieu
2005-10-25 20:30 ` Michael Chan
2005-10-25 23:22 ` Francois Romieu
2005-10-25 22:05 ` Michael Chan
2005-10-26 6:17 Ayaz Abdulla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051024142128.3193bc22@dxpl.pdx.osdl.net \
--to=shemminger@osdl.org \
--cc=aabdulla@nvidia.com \
--cc=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).