From: "John W. Linville" <linville@tuxdriver.com>
To: Bill Moss <bmoss@CLEMSON.EDU>
Cc: netdev@oss.sgi.com, breed@users.sourceforge.net
Subject: Re: airo.c patches
Date: Mon, 31 Oct 2005 16:25:24 -0500 [thread overview]
Message-ID: <20051031212522.GD29670@tuxdriver.com> (raw)
In-Reply-To: <43667B36.3000200@clemson.edu>
On Mon, Oct 31, 2005 at 03:14:46PM -0500, Bill Moss wrote:
> Below are three patches to
> /usr/src/kernels/2.6.13-1.1532_FC4-i686/drivers/net/wireless/airo.c for
> your consideration.
The intended changes look ok at first glance. However, your mailer
has mangled the patches beyond usability. There is tons of whitespace
damage, including the removal of the initial space that should preced
every unchanged line in the patch.
Also, we need a Signed-off-by: line. http://linux.yyz.us/patch-format.html
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
prev parent reply other threads:[~2005-10-31 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-31 20:14 airo.c patches Bill Moss
2005-10-31 21:25 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031212522.GD29670@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=bmoss@CLEMSON.EDU \
--cc=breed@users.sourceforge.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).