netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jouni Malinen <jkmaline@cc.hut.fi>
To: Adrian Bunk <bunk@stusta.de>
Cc: jgarzik@pobox.com, hostap@shmoo.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [2.6 patch] rename hostap.c to hostap_main.c
Date: Sat, 5 Nov 2005 20:15:43 -0800	[thread overview]
Message-ID: <20051106041543.GC8972@jm.kir.nu> (raw)
In-Reply-To: <20051106005343.GF3668@stusta.de>

On Sun, Nov 06, 2005 at 01:53:43AM +0100, Adrian Bunk wrote:
> I wanted to remove the #include "hostap_ioctl.c" from hostap.c and build 
> hostap_ioctl.c separately, but this doesn't work since hostap.c has the 
> same name as the module.

Is this patch changing anything in hostap.c or is it just a rename of
the file? Patch file is not exactly ideal for this kind of changes and I
hope git has a better way of storing this kind of rename.

I would rather not rename the file, but if this is the only way of
getting the module built in pieces, I'm okay with the change (assuming
nothing else changed in hostap.c in this changeset).


> +++ linux-2.6.14-rc5-mm1-full/drivers/net/wireless/hostap/Makefile	2005-11-06 00:14:57.000000000 +0100
> @@ -1,5 +1,7 @@
> -obj-$(CONFIG_HOSTAP_CS) += hostap_cs.o
> -obj-$(CONFIG_HOSTAP_PLX) += hostap_plx.o
> -obj-$(CONFIG_HOSTAP_PCI) += hostap_pci.o
> +obj-$(CONFIG_HOSTAP)		+= hostap.o
> +
> +obj-$(CONFIG_HOSTAP_CS)		+= hostap_cs.o
> +obj-$(CONFIG_HOSTAP_PLX)	+= hostap_plx.o
> +obj-$(CONFIG_HOSTAP_PCI)	+= hostap_pci.o

Why were the hostap_{cs,plx,pci} lines changed? I prefer the original
version of those lines (i.e., no extra padding).

-- 
Jouni Malinen                                            PGP id EFC895FA

  reply	other threads:[~2005-11-06  4:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-06  0:53 [2.6 patch] rename hostap.c to hostap_main.c Adrian Bunk
2005-11-06  4:15 ` Jouni Malinen [this message]
2005-11-13 16:27   ` Adrian Bunk
2005-11-13 16:46     ` Jouni Malinen
2005-11-13 17:34     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051106041543.GC8972@jm.kir.nu \
    --to=jkmaline@cc.hut.fi \
    --cc=bunk@stusta.de \
    --cc=hostap@shmoo.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).