* [PATCH] xtensa platform-iss network: remove no-op ioctl handler
@ 2005-11-07 5:20 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2005-11-07 5:20 UTC (permalink / raw)
To: jgarzik, chris; +Cc: netdev
If the driver ever wants to add ethtool support it should use
ethtool_ops.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/arch/xtensa/platform-iss/network.c
===================================================================
--- linux-2.6.orig/arch/xtensa/platform-iss/network.c 2005-10-31 13:15:49.000000000 +0100
+++ linux-2.6/arch/xtensa/platform-iss/network.c 2005-11-04 15:17:16.000000000 +0100
@@ -611,38 +611,6 @@
return -EINVAL;
}
-static int iss_net_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
-{
-#if 0
- static const struct ethtool_drvinfo info = {
- .cmd = ETHTOOL_GDRVINFO,
- .driver = DRIVER_NAME,
- .version = "42",
- };
- void *useraddr;
- u32 ethcmd;
-
- switch (cmd) {
- case SIOCETHTOOL:
- useraddr = ifr->ifr_data;
- if (copy_from_user(ðcmd, useraddr, sizeof(ethcmd)))
- return -EFAULT;
-
- switch (ethcmd) {
- case ETHTOOL_GDRVINFO:
- if (copy_to_user(useraddr, &info, sizeof(info)))
- return -EFAULT;
- return 0;
- default:
- return -EOPNOTSUPP;
- }
- default:
- return -EINVAL;
- }
-#endif
- return -EINVAL;
-}
-
void iss_net_user_timer_expire(unsigned long _conn)
{
}
@@ -730,7 +698,6 @@
dev->tx_timeout = iss_net_tx_timeout;
dev->set_mac_address = iss_net_set_mac;
dev->change_mtu = iss_net_change_mtu;
- dev->do_ioctl = iss_net_ioctl;
dev->watchdog_timeo = (HZ >> 1);
dev->irq = -1;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-11-07 5:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-07 5:20 [PATCH] xtensa platform-iss network: remove no-op ioctl handler Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).