netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Jan Niehusmann <jan@gondor.com>
Cc: Alejandro Bonilla Beeche <abonilla@linuxwireless.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	James Ketrenos <jketreno@linux.intel.com>
Subject: Re: [PATCH] Re: IPW Question on menuconfig
Date: Mon, 7 Nov 2005 21:04:53 -0500	[thread overview]
Message-ID: <20051108020450.GB25686@tuxdriver.com> (raw)
In-Reply-To: <20051023223658.GA5367@knautsch.gondor.com>

Do we want this patch?  If yes, Jan could you reformat your posting
according to the rules described here:

	http://linux.yyz.us/patch-format.html

Please pay particular attention to formatting your subject and
changelog information.

Thanks,

John

On Mon, Oct 24, 2005 at 12:36:58AM +0200, Jan Niehusmann wrote:
> On Mon, Oct 10, 2005 at 09:00:50PM -0600, Alejandro Bonilla Beeche wrote:
> > Network devices / Wireless, and the IPW2100 wasn't in the list. I went, 
> > then Modularized the IEEE80211 and then IPW2100 was there. I think is 
> > kind of estrange that IPW2100 wouldn't show just because it has a 
> > dependencie, shouldn't IPW2100 show in the list, and if you select it, 
> > then it would also select CONFIG_IEEE80211?
> 
> I think you are right, so the config script should be changed like shown
> below. (But I'm not really familiar with the config language, so I may
> be missing some obvious problems?)
> 
> Signed-off-by: Jan Niehusmann <jan@gondor.com>
> (in case somebody cares for that for such a small change...)
> 
> 
> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
> --- a/drivers/net/wireless/Kconfig
> +++ b/drivers/net/wireless/Kconfig
> @@ -139,8 +139,9 @@ comment "Wireless 802.11b ISA/PCI cards 
>  
>  config IPW2100
>  	tristate "Intel PRO/Wireless 2100 Network Connection"
> -	depends on NET_RADIO && PCI && IEEE80211
> +	depends on NET_RADIO && PCI
>  	select FW_LOADER
> +	select IEEE80211
>  	---help---
>            A driver for the Intel PRO/Wireless 2100 Network 
>  	  Connection 802.11b wireless network adapter.
> @@ -192,8 +193,9 @@ config IPW_DEBUG
>  
>  config IPW2200
>  	tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection"
> -	depends on IEEE80211 && PCI
> +	depends on PCI
>  	select FW_LOADER
> +	select IEEE80211
>  	---help---
>            A driver for the Intel PRO/Wireless 2200BG and 2915ABG Network
>  	  Connection adapters. 
>  
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
John W. Linville
linville@tuxdriver.com

      reply	other threads:[~2005-11-08  2:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-11  3:00 IPW Question on menuconfig Alejandro Bonilla Beeche
2005-10-23 22:36 ` [PATCH] " Jan Niehusmann
2005-11-08  2:04   ` John W. Linville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051108020450.GB25686@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=abonilla@linuxwireless.org \
    --cc=jan@gondor.com \
    --cc=jketreno@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).