From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [PATCH] Re: IPW Question on menuconfig Date: Mon, 7 Nov 2005 21:04:53 -0500 Message-ID: <20051108020450.GB25686@tuxdriver.com> References: <434B2AE2.1070709@linuxwireless.org> <20051023223658.GA5367@knautsch.gondor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alejandro Bonilla Beeche , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, James Ketrenos Return-path: To: Jan Niehusmann Content-Disposition: inline In-Reply-To: <20051023223658.GA5367@knautsch.gondor.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Do we want this patch? If yes, Jan could you reformat your posting according to the rules described here: http://linux.yyz.us/patch-format.html Please pay particular attention to formatting your subject and changelog information. Thanks, John On Mon, Oct 24, 2005 at 12:36:58AM +0200, Jan Niehusmann wrote: > On Mon, Oct 10, 2005 at 09:00:50PM -0600, Alejandro Bonilla Beeche wrote: > > Network devices / Wireless, and the IPW2100 wasn't in the list. I went, > > then Modularized the IEEE80211 and then IPW2100 was there. I think is > > kind of estrange that IPW2100 wouldn't show just because it has a > > dependencie, shouldn't IPW2100 show in the list, and if you select it, > > then it would also select CONFIG_IEEE80211? > > I think you are right, so the config script should be changed like shown > below. (But I'm not really familiar with the config language, so I may > be missing some obvious problems?) > > Signed-off-by: Jan Niehusmann > (in case somebody cares for that for such a small change...) > > > diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig > --- a/drivers/net/wireless/Kconfig > +++ b/drivers/net/wireless/Kconfig > @@ -139,8 +139,9 @@ comment "Wireless 802.11b ISA/PCI cards > > config IPW2100 > tristate "Intel PRO/Wireless 2100 Network Connection" > - depends on NET_RADIO && PCI && IEEE80211 > + depends on NET_RADIO && PCI > select FW_LOADER > + select IEEE80211 > ---help--- > A driver for the Intel PRO/Wireless 2100 Network > Connection 802.11b wireless network adapter. > @@ -192,8 +193,9 @@ config IPW_DEBUG > > config IPW2200 > tristate "Intel PRO/Wireless 2200BG and 2915ABG Network Connection" > - depends on IEEE80211 && PCI > + depends on PCI > select FW_LOADER > + select IEEE80211 > ---help--- > A driver for the Intel PRO/Wireless 2200BG and 2915ABG Network > Connection adapters. > > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- John W. Linville linville@tuxdriver.com