* [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
@ 2005-11-06 2:57 John W. Linville
2005-11-07 7:53 ` Pantelis Antoniou
0 siblings, 1 reply; 5+ messages in thread
From: John W. Linville @ 2005-11-06 2:57 UTC (permalink / raw)
To: linuxppc-embedded; +Cc: netdev, linux-kernel
Make CONFIG_FEC_8XX depend on CONFIG_8xx. This keeps allmodconfig from
breaking on non-8xx (PPC) platforms.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/fec_8xx/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
index 4560026..a84c232 100644
--- a/drivers/net/fec_8xx/Kconfig
+++ b/drivers/net/fec_8xx/Kconfig
@@ -1,6 +1,6 @@
config FEC_8XX
tristate "Motorola 8xx FEC driver"
- depends on NET_ETHERNET
+ depends on NET_ETHERNET && 8xx
select MII
config FEC_8XX_GENERIC_PHY
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
2005-11-06 2:57 [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx John W. Linville
@ 2005-11-07 7:53 ` Pantelis Antoniou
2005-11-07 18:20 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: Pantelis Antoniou @ 2005-11-07 7:53 UTC (permalink / raw)
To: John W. Linville; +Cc: linuxppc-embedded, netdev, linux-kernel
John W. Linville wrote:
> Make CONFIG_FEC_8XX depend on CONFIG_8xx. This keeps allmodconfig from
> breaking on non-8xx (PPC) platforms.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
>
> drivers/net/fec_8xx/Kconfig | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
> index 4560026..a84c232 100644
> --- a/drivers/net/fec_8xx/Kconfig
> +++ b/drivers/net/fec_8xx/Kconfig
> @@ -1,6 +1,6 @@
> config FEC_8XX
> tristate "Motorola 8xx FEC driver"
> - depends on NET_ETHERNET
> + depends on NET_ETHERNET && 8xx
> select MII
>
> config FEC_8XX_GENERIC_PHY
Yes, this is the correct approach. Please disregard the other
patches floating about.
Regards
Pantelis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
2005-11-07 7:53 ` Pantelis Antoniou
@ 2005-11-07 18:20 ` John W. Linville
2005-11-07 18:24 ` [patch 2.6.14 (take #2)] " John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: John W. Linville @ 2005-11-07 18:20 UTC (permalink / raw)
To: Pantelis Antoniou; +Cc: netdev, linux-kernel, linuxppc-embedded
On Mon, Nov 07, 2005 at 09:53:25AM +0200, Pantelis Antoniou wrote:
> John W. Linville wrote:
> >@@ -1,6 +1,6 @@
> > config FEC_8XX
> > tristate "Motorola 8xx FEC driver"
> >- depends on NET_ETHERNET
> >+ depends on NET_ETHERNET && 8xx
> > select MII
> >
> > config FEC_8XX_GENERIC_PHY
>
> Yes, this is the correct approach. Please disregard the other
> patches floating about.
Pretty sure you are right. However, a broken version already got
committed. It added FEC as a dependency. That keeps it from breaking
everyone else, but it make the driver available for Coldfire rather
than for PPC 8xx...
I'll reform that patch and repost.
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch 2.6.14 (take #2)] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
2005-11-07 18:20 ` John W. Linville
@ 2005-11-07 18:24 ` John W. Linville
2005-11-09 21:52 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: John W. Linville @ 2005-11-07 18:24 UTC (permalink / raw)
To: Pantelis Antoniou, linuxppc-embedded, netdev, linux-kernel
Change CONFIG_FEC_8XX to depend on CONFIG_8xx instead of CONFIG_FEC.
CONFIG_FEC depends on ColdFire CPUs, which does not apply for the
PPC 8xx processors.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/fec_8xx/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
index 94e7a9a..a84c232 100644
--- a/drivers/net/fec_8xx/Kconfig
+++ b/drivers/net/fec_8xx/Kconfig
@@ -1,6 +1,6 @@
config FEC_8XX
tristate "Motorola 8xx FEC driver"
- depends on NET_ETHERNET && FEC
+ depends on NET_ETHERNET && 8xx
select MII
config FEC_8XX_GENERIC_PHY
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch 2.6.14 (take #2)] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
2005-11-07 18:24 ` [patch 2.6.14 (take #2)] " John W. Linville
@ 2005-11-09 21:52 ` John W. Linville
0 siblings, 0 replies; 5+ messages in thread
From: John W. Linville @ 2005-11-09 21:52 UTC (permalink / raw)
To: Pantelis Antoniou, linuxppc-embedded, netdev, linux-kernel
On Mon, Nov 07, 2005 at 01:24:59PM -0500, John W. Linville wrote:
> Change CONFIG_FEC_8XX to depend on CONFIG_8xx instead of CONFIG_FEC.
> CONFIG_FEC depends on ColdFire CPUs, which does not apply for the
> PPC 8xx processors.
FWIW, I have this patch available on the linville-fec_8xx branch of
netdev-jwl as described below.
Thanks,
John
---
The following changes since commit 330d57fb98a916fa8e1363846540dd420e99499a:
Al Viro:
Fix sysctl unregistration oops (CVE-2005-2709)
are found in the git repository at:
git://git.tuxdriver.com/git/netdev-jwl.git linville-fec_8xx
John W. Linville:
fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
drivers/net/fec_8xx/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
index 94e7a9a..a84c232 100644
--- a/drivers/net/fec_8xx/Kconfig
+++ b/drivers/net/fec_8xx/Kconfig
@@ -1,6 +1,6 @@
config FEC_8XX
tristate "Motorola 8xx FEC driver"
- depends on NET_ETHERNET && FEC
+ depends on NET_ETHERNET && 8xx
select MII
config FEC_8XX_GENERIC_PHY
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-11-09 21:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-06 2:57 [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx John W. Linville
2005-11-07 7:53 ` Pantelis Antoniou
2005-11-07 18:20 ` John W. Linville
2005-11-07 18:24 ` [patch 2.6.14 (take #2)] " John W. Linville
2005-11-09 21:52 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).