From: Brian Pomerantz <bapper@piratehaven.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org, davem@davemloft.net,
kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@coreworks.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion
Date: Wed, 16 Nov 2005 11:21:09 -0800 [thread overview]
Message-ID: <20051116192109.GA23233@skull.piratehaven.org> (raw)
In-Reply-To: <4370B203.8070501@trash.net>
On Tue, Nov 08, 2005 at 03:11:15PM +0100, Patrick McHardy wrote:
>
> Yes, fixing it correctly looks very hard. Just changing the routes
> doesn't seem right to me, someone might have added it with exactly
> this prefsrc and doesn't want it to change, its also not clear how
> to notify on this. Taking care of correct ordering of the ifa_list
> is also more complicated without just deleting and readding them.
>
> I have a patch to do this, but it needs some debugging, for some
> unknown reason it crashes sometimes if I remove addresses without
> specifying the mask.
Looks like I'm back on this one because just sending the NETDEV_UP for
the secondaries didn't work if a primary other than the first one is
removed. If you have anything that you need help testing/debugging,
I'm stuck with this until it is fixed. I'd prefer not to duplicate
effort on this if you're close to a fix. If not, then I'll try to
come up with something and toss it out for comment.
BAPper
next prev parent reply other threads:[~2005-11-16 19:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 18:46 [PATCH] [IPV4] Fix secondary IP addresses after promotion Brian Pomerantz
2005-11-05 0:34 ` Patrick McHardy
2005-11-05 0:58 ` Brian Pomerantz
2005-11-05 1:07 ` Thomas Graf
2005-11-05 1:21 ` Patrick McHardy
2005-11-05 4:28 ` Patrick McHardy
2005-11-05 13:46 ` Thomas Graf
2005-11-07 21:50 ` Thomas Graf
2005-11-08 14:11 ` Patrick McHardy
2005-11-09 0:56 ` Thomas Graf
2005-11-11 13:16 ` Patrick McHardy
2005-11-16 19:21 ` Brian Pomerantz [this message]
2005-11-05 18:39 ` Alexey Kuznetsov
2005-11-05 19:06 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051116192109.GA23233@skull.piratehaven.org \
--to=bapper@piratehaven.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).