From: Adrian Bunk <bunk@stusta.de>
To: proski@gnu.org, orinoco-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, jgarzik@pobox.com,
netdev@vger.kernel.org
Subject: Re: [Orinoco-devel] [2.6 patch] drivers/net/wireless/orinoco.h: "extern inline" -> "static inline"
Date: Fri, 18 Nov 2005 05:00:09 +0100 [thread overview]
Message-ID: <20051118040009.GZ11494@stusta.de> (raw)
In-Reply-To: <20051118035236.GB23760@localhost.localdomain>
On Fri, Nov 18, 2005 at 02:52:36PM +1100, David Gibson wrote:
> On Fri, Nov 18, 2005 at 04:33:29AM +0100, Adrian Bunk wrote:
> > "extern inline" doesn't make much sense.
>
> Yes it does. "extern inline" tells gcc not to fall back to out of
> line version if it can't inline the function. These functions *must*
> by inlined, or they'll break horribly on Sparc, at least.
>...
For any non-ancient gcc and !alpha, we are already telling gcc via
__attribute__((always_inline)) that it should abort compilation if it
can't inline the function.
The problem is that "extern inline" gives warnings with
-Wmissing-prototypes, and I want to add this flag to the CFLAGS since it
helps us to avoid a class of nasty runtime errors.
> David Gibson
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2005-11-18 4:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 3:33 [2.6 patch] drivers/net/wireless/orinoco.h: "extern inline" -> "static inline" Adrian Bunk
[not found] ` <20051118033329.GU11494-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2005-11-18 3:52 ` David Gibson
2005-11-18 4:00 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051118040009.GZ11494@stusta.de \
--to=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).