From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
dada1@cosmosbay.com
Subject: Re: [PATCH] [RFT] ip_tables NUMA optimization
Date: Sat, 19 Nov 2005 09:45:47 +0100 [thread overview]
Message-ID: <20051119084547.GC20775@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20051118.160043.119281166.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Fri, Nov 18, 2005 at 04:00:43PM -0800, David S. Miller wrote:
> > It should probably use vfree() like :
> >
> > > + for_each_cpu(cpu) {
> > > + if (info->size <= PAGE_SIZE)
> > > + kfree(info->entries[cpu]);
> > > + else
> > > + vfree(info->entries[cpu]);
> > > + }
>
> I've put the patch into the net-2.6.16 tree with the obvious
> fix Eric points out.
thanks!
--
- Harald Welte <laforge@netfilter.org> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-11-19 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 14:43 [PATCH] [RFT] ip_tables NUMA optimization Harald Welte
2005-11-17 15:21 ` Eric Dumazet
2005-11-19 0:00 ` David S. Miller
2005-11-19 8:45 ` Harald Welte [this message]
2005-11-19 10:31 ` [PATCH] NETFILTER arp_tables: Fix " Harald Welte
2005-11-22 22:28 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051119084547.GC20775@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).