From: "David S. Miller" <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: kuznet@ms2.inr.ac.ru, cfriesen@nortel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [NETLINK]: Use tgid instead of pid for nlmsg_pid
Date: Tue, 22 Nov 2005 14:43:34 -0800 (PST) [thread overview]
Message-ID: <20051122.144334.23915283.davem@davemloft.net> (raw)
In-Reply-To: <E1EeJxb-0006xG-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 22 Nov 2005 09:16:27 +1100
> Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> wrote:
> >
> > I agree, apparently netlink_autobind was missed when sed'ing pid->tgid.
> > Of course, it does not matter, but tgid is nicer choice from user's viewpoint.
>
> Great, here is the patch to do just that.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, of course.
I can't for the life of me figure out how we missed this when
we fixed up all the current->pid references under net/.
Ulrich Drepper let us know that the problem existed, and
I was sure we eliminated all such cases.
It is possible we accidently reintroduced current->pid when
we redid all of the netlink hashing. :-)
next prev parent reply other threads:[~2005-11-22 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 19:32 netlink nlmsg_pid supposed to be pid or tid? Christopher Friesen
2005-11-21 19:46 ` Christopher Friesen
2005-11-21 20:51 ` Herbert Xu
2005-11-21 21:35 ` Alexey Kuznetsov
2005-11-21 21:47 ` Christopher Friesen
2005-11-21 22:15 ` Herbert Xu
2005-11-21 22:51 ` Christopher Friesen
2005-11-22 0:09 ` Herbert Xu
2005-11-21 22:49 ` Alexey Kuznetsov
2005-11-21 23:34 ` Herbert Xu
2005-11-21 22:16 ` [NETLINK]: Use tgid instead of pid for nlmsg_pid Herbert Xu
2005-11-22 22:43 ` David S. Miller [this message]
2005-11-23 0:03 ` Herbert Xu
2005-11-23 6:18 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051122.144334.23915283.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cfriesen@nortel.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).