From: Sam Ravnborg <sam@ravnborg.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: kaber@trash.net, bunk@stusta.de, evil@g-house.de,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
zippel@linux-m68k.org
Subject: Re: [2.6 patch] do not select NET_CLS
Date: Wed, 23 Nov 2005 06:57:35 +0100 [thread overview]
Message-ID: <20051123055735.GC7579@mars.ravnborg.org> (raw)
In-Reply-To: <20051122.150041.90521592.davem@davemloft.net>
On Tue, Nov 22, 2005 at 03:00:41PM -0800, David S. Miller wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> Date: Tue, 22 Nov 2005 23:49:14 +0100
>
> > On Tue, Nov 22, 2005 at 02:37:13PM -0800, David S. Miller wrote:
> > >
> > > One thing we can do to prevent human
> > > mistakes, is to make the "make modules" pass do a quick "is vmlinux
> > > uptodate?" check, and if not print out an error message explaining the
> > > situation and aborting the "make modules" attempt.
> >
> > I do not quite follow you here.
>
> If the user tries to do a "make modules" without first rebuilding
> their kernel image, then the make will fail if the dependencies
> are not satisfied for the main kernel image and it is thus not
> up to date.
OK - so a simple 'make -q vmlinux' check, except that the way we utilise
make will let it fail at first build command.
That will obscufate things even more in kbuild - but I will give it a
try sometime. It will be easy to cover 95% but to reach 100%
predictability will be though.
- file dependencies is easy
- command line changes is relatively easy
- but the various scripts and user commands will be tricky..
Not on the top of the TODO list though.
Sam
next prev parent reply other threads:[~2005-11-23 5:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <437BBC59.70301@g-house.de>
2005-11-16 23:58 ` 2.6.15-rc1: NET_CLS_U32 not working? Adrian Bunk
2005-11-17 0:06 ` Christian
2005-11-17 15:57 ` Christian
2005-11-21 15:59 ` [2.6 patch] do not select NET_CLS Adrian Bunk
2005-11-21 16:16 ` Patrick McHardy
2005-11-22 22:37 ` David S. Miller
2005-11-22 22:49 ` Sam Ravnborg
2005-11-22 23:00 ` David S. Miller
2005-11-23 5:57 ` Sam Ravnborg [this message]
2005-11-24 2:13 ` Randy.Dunlap
2005-11-24 5:40 ` Sam Ravnborg
2005-11-22 23:12 ` Adrian Bunk
2005-11-23 10:27 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123055735.GC7579@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=evil@g-house.de \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).