From: Adrian Bunk <bunk@stusta.de>
To: "Lever, Charles" <Charles.Lever@netapp.com>
Cc: David Miller <davem@davemloft.net>,
neilb@cse.unsw.edu.au, trond.myklebust@fys.uio.no,
linux-kernel@vger.kernel.org, nfs@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string()
Date: Wed, 23 Nov 2005 17:25:28 +0100 [thread overview]
Message-ID: <20051123162528.GL3963@stusta.de> (raw)
In-Reply-To: <044B81DE141D7443BCE91E8F44B3C1E2013327DF@exsvl02.hq.netapp.com>
On Wed, Nov 23, 2005 at 04:31:14AM -0800, Lever, Charles wrote:
> > On Thu, Oct 06, 2005 at 07:13:14AM -0700, Lever, Charles wrote:
> >
> > > actually, can we hold off on this change? the RPC
> > transport switch will
> > > eventually need most of those EXPORT_SYMBOLs.
> >
> > Am I right to assume this will happen in the foreseeable future?
>
> the first portion of the transport switch is in 2.6.15-rcX. at this
> point i'm expecting the EXPORT_SYMBOL changes to go in 2.6.17 or later.
OK.
> so i don't remember why you are removing xdr_decode_string. are we sure
> that no-one will need this functionality in the future? it is harmless
> to remove today, but i wonder if someone is just going to add it back
> sometime.
It's unused and you said:
the only harmless change i see below is removing xdr_decode_string().
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-11-23 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 12:31 [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string() Lever, Charles
2005-11-23 16:25 ` Adrian Bunk [this message]
2005-11-23 23:07 ` Neil Brown
-- strict thread matches above, loose matches on Subject: below --
2005-12-14 21:10 Adrian Bunk
2005-11-24 6:56 Lever, Charles
2005-10-06 14:13 [NFS] [RFC: 2.6 patch] net/sunrpc/: possible cleanups Lever, Charles
2005-11-23 1:24 ` [2.6 patch] net/sunrpc/xdr.c: remove xdr_decode_string() Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123162528.GL3963@stusta.de \
--to=bunk@stusta.de \
--cc=Charles.Lever@netapp.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=netdev@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).