From: Jeff Garzik <jgarzik@pobox.com>
To: Ingo Oeser <netdev@axxeo.de>
Cc: Andrew Grover <andrew.grover@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
john.ronciak@intel.com, christopher.leech@intel.com
Subject: Re: [RFC] [PATCH 1/3] ioat: DMA subsystem
Date: Thu, 24 Nov 2005 10:04:33 -0500 [thread overview]
Message-ID: <20051124150433.GA3590@havoc.gtf.org> (raw)
In-Reply-To: <200511241600.50046.netdev@axxeo.de>
On Thu, Nov 24, 2005 at 04:00:50PM +0100, Ingo Oeser wrote:
> Hi,
>
> Jeff Garzik wrote:
> > explanation of this function would be nice. remember to answer "how?"
> > and "why?", not "what?".
>
> Wasn't it the other way around?
> Citing linux/Documentation/CodingStyle, section 7 "Comments":
>
> "Generally, you want your comments to tell WHAT your code does, not HOW."
>
> HOW and WHY should be obvious by the source code, unless
> the sources are a mess.
Yes, good point, thanks for the correction.
Jeff
next prev parent reply other threads:[~2005-11-24 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 20:26 [RFC] [PATCH 1/3] ioat: DMA subsystem Andrew Grover
2005-11-23 21:51 ` David S. Miller
2005-11-23 22:44 ` Jeff Garzik
2005-11-24 15:00 ` Ingo Oeser
2005-11-24 15:04 ` Jeff Garzik [this message]
2005-11-28 22:57 ` Andrew Grover
2005-11-24 0:07 ` Greg KH
2005-11-24 11:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051124150433.GA3590@havoc.gtf.org \
--to=jgarzik@pobox.com \
--cc=andrew.grover@intel.com \
--cc=christopher.leech@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).