From: Johannes Stezenbach <js@linuxtv.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH linux-2.6.15-rc5] sk98lin: rx checksum offset not set
Date: Mon, 5 Dec 2005 20:22:39 +0100 [thread overview]
Message-ID: <20051205192239.GA4150@linuxtv.org> (raw)
In-Reply-To: <20051205110040.47adf428@localhost.localdomain>
On Mon, Dec 05, 2005, Stephen Hemminger wrote:
> The checksum offsets for receive offload were not being set correctly.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
I can confirm that this patch fixes the problem for me.
Thanks,
Johannes
> Index: linux-2.6/drivers/net/sk98lin/skge.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/sk98lin/skge.c
> +++ linux-2.6/drivers/net/sk98lin/skge.c
> @@ -818,7 +818,7 @@ uintptr_t VNextDescr; /* the virtual bus
> /* set the pointers right */
> pDescr->VNextRxd = VNextDescr & 0xffffffffULL;
> pDescr->pNextRxd = pNextDescr;
> - pDescr->TcpSumStarts = 0;
> + if (!IsTx) pDescr->TcpSumStarts = ETH_HLEN << 16 | ETH_HLEN;
>
> /* advance one step */
> pPrevDescr = pDescr;
> @@ -2169,7 +2169,7 @@ rx_start:
> } /* frame > SK_COPY_TRESHOLD */
>
> #ifdef USE_SK_RX_CHECKSUM
> - pMsg->csum = pRxd->TcpSums;
> + pMsg->csum = pRxd->TcpSums & 0xffff;
> pMsg->ip_summed = CHECKSUM_HW;
> #else
> pMsg->ip_summed = CHECKSUM_NONE;
>
next prev parent reply other threads:[~2005-12-05 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0512032155290.3099@g5.osdl.org>
2005-12-04 23:43 ` Linux 2.6.15-rc5: sk98lin broken Johannes Stezenbach
2005-12-05 19:00 ` [PATCH linux-2.6.15-rc5] sk98lin: rx checksum offset not set Stephen Hemminger
2005-12-05 19:22 ` Johannes Stezenbach [this message]
2005-12-05 19:13 ` Linux 2.6.15-rc5: sk98lin broken Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205192239.GA4150@linuxtv.org \
--to=js@linuxtv.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).