Netdev List
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: jaco@kroon.co.za
Cc: netdev@vger.kernel.org, lkml@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: [KJ] Re: [PATCH] Deinitialise static variables in net/core/pktgen.c
Date: Thu, 22 Dec 2005 12:52:32 -0800 (PST)	[thread overview]
Message-ID: <20051222.125232.110191612.davem@davemloft.net> (raw)
In-Reply-To: <17299.192.96.150.57.1135065563.squirrel@mail.interexcel.co.za>

[-- Attachment #1: Type: Text/Plain, Size: 689 bytes --]

From: "Jaco Kroon" <jaco@kroon.co.za>
Date: Tue, 20 Dec 2005 09:59:23 +0200 (SAST)

> static variables should not be explicitly initialised to 0.  This causes
> them to be placed in .data instead of .bss.  This patch de-initialises 3
> static variables in net/core/pktgen.c.
> 
> There are approximately 800 more such variables in the source tree
> (2.6.15rc5).  If there is more interrest I'd be willing to track down the
> rest of these as well and de-initialise them as well.

Applied, _but_:

1) Please provide a "Signed-off-by: " line next time.
2) Please send the patches in such a way that your email
   client doesn't corrupt that patch, there were newlines
   added etc.

Thanks.

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      reply	other threads:[~2005-12-22 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-20  7:59 [KJ] [PATCH] Deinitialise static variables in net/core/pktgen.c Jaco Kroon
2005-12-22 20:52 ` David S. Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051222.125232.110191612.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jaco@kroon.co.za \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=lkml@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox