From: "David S. Miller" <davem@davemloft.net>
To: manfred@dbl.q-ag.de
Cc: jgarzik@pobox.com, aabdulla@nvidia.com, afu@fugmann.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
torvalds@osdl.org
Subject: Re: [PATCH] forcedeth: TSO fix for large buffers
Date: Sun, 25 Dec 2005 12:57:42 -0800 (PST) [thread overview]
Message-ID: <20051225.125742.65007619.davem@davemloft.net> (raw)
In-Reply-To: <200512251451.jBPEpgNe018712@dbl.q-ag.de>
From: Manfred Spraul <manfred@dbl.q-ag.de>
Date: Sun, 25 Dec 2005 15:51:42 +0100
> This patch contains a bug fix for large buffers. Originally, if a tx
> buffer to be sent was larger then the maximum size of the tx descriptor,
>
> it would overwrite other control bits. In this patch, the buffer is
> split over multiple descriptors. Also, the fragments are now setup in
> forward order.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
>
> Rediffed against forcedeth 0.48
> Signed-Off-By: Manfred Spraul <manfred@colorfullife.com>
Are you sure it's ok to setup the tx descriptors in that order?
Usually, you need to set them up last to first so that the chip
doesn't see a half-filled-in set of TX descriptors. Ie. the
core question is if the chip can scan the TX descriptors looking
for valid ones all on it's own after processing existing TX
descriptors, or do you have to explicitly allow the chip look
at the newly added TX descriptor with a register write or similar?
next prev parent reply other threads:[~2005-12-25 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 14:51 [PATCH] forcedeth: TSO fix for large buffers Manfred Spraul
2005-12-25 20:57 ` David S. Miller [this message]
2003-01-26 22:54 ` Ayaz Abdulla
2006-01-03 20:33 ` Manfred Spraul
2006-01-04 6:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051225.125742.65007619.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aabdulla@nvidia.com \
--cc=afu@fugmann.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@dbl.q-ag.de \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).