From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4F0CA9EAF for ; Thu, 24 Oct 2019 17:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F87020578 for ; Thu, 24 Oct 2019 17:17:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="DTf+dLTF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439985AbfJXRRE (ORCPT ); Thu, 24 Oct 2019 13:17:04 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:35777 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439972AbfJXRRE (ORCPT ); Thu, 24 Oct 2019 13:17:04 -0400 Received: by mail-io1-f68.google.com with SMTP id h9so2648228ioh.2 for ; Thu, 24 Oct 2019 10:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xk35OIRZgG5X6bY5L2C8Cgvh/RkMCx5ztmO2WbT4NXQ=; b=DTf+dLTFxav94WxX6yhgdpYy/IQvWV2zfvGoCMkmU/8/HwwCvUN69ASmiBoukX/usV bThlqPFVEfKMVmvNqNLVsUoP+4wn+oSLoPovTJxfowQyMbSzOS/86Vxxwp16wlIoJTkp 8c/vQyx2MkRKUR5uZLqPh4PTSOnQ5cYHd4bDRxFWG68EHyR1lAMjqAqTOWE883S18ItW EOUWWrQSDM8hhT++NKj8jmUVB1AYWt2wDUSfnmickY95qQZr80a67ToQOmIlWYDBqRtS D4Tmx1vkRf22qmk1+Dn8KLhn+Dr5r2peG8zeEyfLeirfwmvHqMn0BhF2dL+8nCIizlwe 0UuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xk35OIRZgG5X6bY5L2C8Cgvh/RkMCx5ztmO2WbT4NXQ=; b=EcPqmsmSe1pB+iZUuOVL0HqzQnDHlW58Kt25jk5YpF6Rm2hmGZ+xpKBrG8eP2d9IfN Y3IsyjkqKcACQSkC626TZiOznl8s0C+1Jd7LkGfZcbWNvonL4uv9TzWUapqflJYgAVqr penSjxt8rLE2ueWTeH26I9YnRtl0Pptkae/osbfKhj76/kDOjLD3dPXJereBPN3VjGtR ff/kKe15xWlSs45Xb4+0ZlREyO9Hwl4i2oOY0vL04azPSYzAVtnXrTJxqMzBFFxopJB/ opIessVtLh9kpAFUybz37tDxkxcchmIzGkzBNValJB0sD2HD4iI4nvXQ82pnQoDV34Ia xDwA== X-Gm-Message-State: APjAAAVwuxPCVtpbDiGUpGbHcULUL1ywhv++Zb+0xVq5eNIXSnSFaKjH iVEpYMvvnxPrP4zbNDQDYqspYA== X-Google-Smtp-Source: APXvYqxxmknicfMVGH+Z2m02iqW4923v2h94gLRe9KkGB2gNwBW0RHU4jv2mPkIgxQG/4TJBesVXqg== X-Received: by 2002:a5d:9393:: with SMTP id c19mr7623084iol.37.1571937423226; Thu, 24 Oct 2019 10:17:03 -0700 (PDT) Received: from [10.0.0.194] ([64.26.149.125]) by smtp.googlemail.com with ESMTPSA id z19sm2432526ilj.49.2019.10.24.10.17.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Oct 2019 10:17:02 -0700 (PDT) Subject: Re: [PATCH net-next 00/13] Control action percpu counters allocation by netlink flag To: Vlad Buslov Cc: Jiri Pirko , "netdev@vger.kernel.org" , "xiyou.wangcong@gmail.com" , "davem@davemloft.net" , "mleitner@redhat.com" , "dcaratti@redhat.com" , Eric Dumazet References: <20191022141804.27639-1-vladbu@mellanox.com> <78ec25e4-dea9-4f70-4196-b93fbc87208d@mojatatu.com> <20191024073557.GB2233@nanopsycho.orion> <90c329f6-f2c6-240f-f9c1-70153edd639f@mojatatu.com> From: Jamal Hadi Salim Message-ID: <200557cb-59a9-4dd7-b317-08d2dac8fa96@mojatatu.com> Date: Thu, 24 Oct 2019 13:17:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Vlad, On 2019-10-24 12:44 p.m., Vlad Buslov wrote: > > Well, I like having it per-action better because of reasons I explained > before (some actions don't use percpu allocator at all and some actions > that are not hw offloaded don't need it), but I think both solutions > have their benefits and drawbacks, so I'm fine with refactoring it. > I am happy you are doing all this great work already. I would be happier if you did it at the root level. It is something that we have been meaning to deal with for a while now. > Do you have any opinion regarding flag naming? Several people suggested > to be more specific, but I strongly dislike the idea of hardcoding the > name of a internal kernel data structure in UAPI constant that will > potentially outlive the data structure by a long time. Could you not just name the bit with a define to say what the bit is for and still use the top level flag? Example we have a bit called "TCA_FLAG_LARGE_DUMP_ON" cheers, jamal