From: Matthew Wilcox <matthew@wil.cx>
To: Daniel Drake <dsd@gentoo.org>
Cc: Jon Mason <jdmason@us.ibm.com>,
mulix@mulix.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: pcnet32 devices with incorrect trident vendor ID
Date: Thu, 12 Jan 2006 14:05:59 -0700 [thread overview]
Message-ID: <20060112210559.GL19769@parisc-linux.org> (raw)
In-Reply-To: <20060112205714.GK19769@parisc-linux.org>
On Thu, Jan 12, 2006 at 01:57:14PM -0700, Matthew Wilcox wrote:
> On Thu, Jan 12, 2006 at 08:49:42PM +0000, Daniel Drake wrote:
> > interesting:
> >
> > http://forums.gentoo.org/viewtopic-t-420013-highlight-trident.html
> >
> > The user saw the correct vendor ID (AMD) in 2.4, but when upgrading to
> > 2.6, it changed to Trident.
>
> It looks to me like there used to be a quirk that knew about this bug
> and fixed it.
>
> The reason I say this is that the lspci -x dumps are the same -- both
> featuring the wrong vendor ID. Want to dig through 2.4 and look for
> this quirk?
Oh -- found it. It's still in 2.6:
static void
fixup_broken_pcnet32(struct pci_dev* dev)
{
if ((dev->class>>8 == PCI_CLASS_NETWORK_ETHERNET)) {
dev->vendor = PCI_VENDOR_ID_AMD;
pci_write_config_word(dev, PCI_VENDOR_ID, PCI_VENDOR_ID_AMD);
}
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TRIDENT, PCI_ANY_ID,
fixup_broken_pcnet32);
Wonder why it isn't working now ... someone with a PPC box needs to check
(a) whether this function is being called and (b) if it is called, why
it's not doing what it's supposed to.
next prev parent reply other threads:[~2006-01-12 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060112175051.GA17539@us.ibm.com>
2006-01-12 20:49 ` pcnet32 devices with incorrect trident vendor ID Daniel Drake
2006-01-12 20:57 ` Matthew Wilcox
2006-01-12 21:03 ` Daniel Drake
2006-01-12 21:05 ` Matthew Wilcox [this message]
2006-01-12 21:22 ` Bill Nottingham
2006-01-12 21:24 ` Bill Nottingham
2006-01-12 22:23 ` Don Fry
2006-01-12 22:33 ` Jon Mason
2006-01-12 21:05 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060112210559.GL19769@parisc-linux.org \
--to=matthew@wil.cx \
--cc=dsd@gentoo.org \
--cc=jdmason@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mulix@mulix.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).