Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error

[Denis Vlasenko <vda@ilport.com.ua>]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Tuesday 31 January 2006 11:03, Gabriel C. wrote:
> > > > I got this compile error with 2.6.16-rc1-mm4 , config attached. 
> > > > 
> > > > 
> > > >   LD      .tmp_vmlinux1
> > > > drivers/built-in.o: In function
> > > > `acx_l_transmit_authen1':common.c:(.text+0x6cd62): undefined
> > > > reference to `acxusb_l_alloc_tx' :common.c:(.text+0x6cd74):
> > > > undefined reference to
> > > > `acxusb_l_get_txbuf' :common.c:(.text+0x6cdeb): undefined
> > > > reference to `acxusb_l_tx_data' drivers/built-in.o: In function
> > > > `acx_s_configure_debug': undefined reference to
> > > > `acxusb_s_issue_cmd_timeo_debug' drivers/built-in.o: In function
> > > > [many more]
> > > >...
> > > 
> > > Thanks for your report.
> > > 
> > > @Denis:
> > > The problem seems to be CONFIG_ACX=y, CONFIG_ACX_USB=n.
> > 
> > Thanks, will test/fix ASAP.

CONFIG_ACX=y
# CONFIG_ACX_PCI is not set
# CONFIG_ACX_USB is not set

This won't fly. You must select at least one.

Attached patch will check for this and #error out.
Andrew, do not apply to -mm, I'll send you bigger update today.
--
vda

[-- Attachment #2: acx.patch --]
[-- Type: text/x-diff, Size: 660 bytes --]

diff -urpN linux-2.6.16-rc1-mm4.org/drivers/net/wireless/tiacx.org/acx_struct.h linux-2.6.16-rc1-mm4.org/drivers/net/wireless/tiacx/acx_struct.h
--- linux-2.6.16-rc1-mm4.org/drivers/net/wireless/tiacx.org/acx_struct.h	Tue Jan 31 12:13:53 2006
+++ linux-2.6.16-rc1-mm4.org/drivers/net/wireless/tiacx/acx_struct.h	Tue Jan 31 13:51:18 2006
@@ -121,6 +121,10 @@ enum { acx_debug = 0 };
 #define DEVTYPE_PCI		0
 #define DEVTYPE_USB		1
 
+#if !defined(CONFIG_ACX_PCI) && !defined(CONFIG_ACX_USB)
+#error Driver must include PCI and/or USB support. You selected neither.
+#endif
+
 #if defined(CONFIG_ACX_PCI)
  #if !defined(CONFIG_ACX_USB)
   #define IS_PCI(priv)	1