From: Denis Vlasenko <vda@ilport.com.ua>
To: Adrian Bunk <bunk@stusta.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"Gabriel C." <crazy@pimpmylinux.org>,
da.crew@gmx.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error
Date: Wed, 1 Feb 2006 08:57:04 +0200 [thread overview]
Message-ID: <200602010857.04964.vda@ilport.com.ua> (raw)
In-Reply-To: <20060131221637.GJ3986@stusta.de>
On Wednesday 01 February 2006 00:16, Adrian Bunk wrote:
> > > > CONFIG_ACX=y
> > > > # CONFIG_ACX_PCI is not set
> > > > # CONFIG_ACX_USB is not set
> > > >
> > > > This won't fly. You must select at least one.
> > > >
> > > > Attached patch will check for this and #error out.
> > > > Andrew, do not apply to -mm, I'll send you bigger update today.
> > >
> > > Is there any way to move this into a Kconfig file? That seems nicer
> > > than having #ifdefs in source code to check for a configuration error.
> >
> > Can't think of any at the moment.
>
> There are two possible solutions ("offer" means "is user visible"):
> - only offer ACX and always build ACX_PCI/ACX_USB depending on the
> availability of PCI/USB
> - only offer ACX_PCI and ACX_USB which select ACX
>
> If you tell me which you prefer I can send a patch.
Second one sounds okay to me.
--
vda
next prev parent reply other threads:[~2006-02-01 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060130133833.7b7a3f8e@zwerg>
2006-01-30 18:10 ` 2.6.16-rc1-mm4: ACX=y, ACX_USB=n compile error Adrian Bunk
2006-01-31 6:10 ` Denis Vlasenko
2006-01-31 9:03 ` Gabriel C.
2006-01-31 12:16 ` Denis Vlasenko
2006-01-31 14:54 ` John W. Linville
2006-01-31 14:58 ` Denis Vlasenko
2006-01-31 18:34 ` Gabriel C.
2006-01-31 18:59 ` Carlos Martín
2006-01-31 22:16 ` Adrian Bunk
2006-02-01 6:57 ` Denis Vlasenko [this message]
2006-02-05 5:02 ` [-mm patch] let only ACX_PCI/ACX_USB be user-visible and select ACX accordingly Adrian Bunk
2006-01-30 18:23 ` [2.6 patch] PCMCIA=m, HOSTAP_CS=y is not a legal configuration Adrian Bunk
2006-01-30 20:30 ` Gabriel C.
2006-01-31 16:19 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602010857.04964.vda@ilport.com.ua \
--to=vda@ilport.com.ua \
--cc=bunk@stusta.de \
--cc=crazy@pimpmylinux.org \
--cc=da.crew@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).