From: Willy Tarreau <willy@w.ods.org>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Mws <mws@twisted-brains.org>,
Alistair John Strachan <s0348365@sms.ed.ac.uk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.16, sk98lin out of date
Date: Mon, 13 Feb 2006 21:34:34 +0100 [thread overview]
Message-ID: <20060213203434.GI11380@w.ods.org> (raw)
In-Reply-To: <1139857394.3202.38.camel@mindpipe>
On Mon, Feb 13, 2006 at 02:03:14PM -0500, Lee Revell wrote:
> On Mon, 2006-02-13 at 12:06 +0100, Mws wrote:
> > hi,
> > as i do have the same problem i may help you out.
> >
> > at first, syskonnect did send their kernel diffs/patches but they
> > we're rejected caused
> > by coding style, indention and some people thinking that things can be
> > done better.
>
> Haha, they didn't like the LKML code review so they just stopped sending
> patches? Classic. Remind me not to buy their gear.
Lee, it's not always that simple. When you submit one driver, sometimes
reviewers tell you that for whatever reason your driver's structure is
wrong and it has to be changed a lot (and sometimes they're right of
course). But when you don't have enough ressource to do the job twice,
the best you can do is to maintain it out of tree, which is already a
pain. I'm not saying that it is what happened with their driver, I don't
know the history. However, I found your reaction somewhat hasty. I
personally would prefer to offer time and help before deciding that
I don't want anyone's products on this basis. It's not as if they
did not release their driver's source !
Cheers,
Willy
next prev parent reply other threads:[~2006-02-13 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 10:58 2.6.16, sk98lin out of date Alistair John Strachan
2006-02-13 11:05 ` Matti Aarnio
2006-02-13 11:10 ` Alistair John Strachan
2006-02-13 19:48 ` Daniel Drake
2006-02-13 23:15 ` Alistair John Strachan
2006-02-13 11:06 ` Mws
2006-02-13 19:03 ` Lee Revell
2006-02-13 20:34 ` Willy Tarreau [this message]
2006-02-13 20:40 ` Lee Revell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213203434.GI11380@w.ods.org \
--to=willy@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mws@twisted-brains.org \
--cc=netdev@vger.kernel.org \
--cc=rlrevell@joe-job.com \
--cc=s0348365@sms.ed.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).