From: Michael Buesch <mbuesch-KuiJ5kEpwI6ELgA04lAiVw@public.gmane.org>
To: Jiri Benc <jbenc-AlSwsSmVLrQ@public.gmane.org>
Cc: "John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
NetDev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: Re: [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module
Date: Wed, 15 Feb 2006 22:34:35 +0100 [thread overview]
Message-ID: <200602152234.35463.mbuesch@freenet.de> (raw)
In-Reply-To: <20060215202147.69b82ee2-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On Wednesday 15 February 2006 20:21, you wrote:
> This patch fixes an oops when bcm43xx-d80211 module is unloaded.
This is already fixed in my tree.
> Signed-off-by: Jiri Benc <jbenc-AlSwsSmVLrQ@public.gmane.org>
>
> --- dscape.testing.orig/drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c 2006-02-15 20:06:07.000000000 +0100
> +++ dscape.testing/drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c 2006-02-15 20:07:17.000000000 +0100
> @@ -4785,7 +4785,8 @@ static void __devexit bcm43xx_remove_one
> ieee80211_unregister_hw(net_dev);
> bcm43xx_detach_board(bcm);
> destroy_workqueue(bcm->workqueue);
> - kfree_skb(bcm->cached_beacon);
> + if (bcm->cached_beacon)
> + kfree_skb(bcm->cached_beacon);
> assert(bcm->ucode == NULL);
> ieee80211_free_hw(net_dev);
> kfree(ieee);
>
>
--
Greetings Michael.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next parent reply other threads:[~2006-02-15 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060215202147.69b82ee2@griffin.suse.cz>
[not found] ` <20060215202147.69b82ee2-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
2006-02-15 21:34 ` Michael Buesch [this message]
[not found] ` <20060216103543.5a96f0a0@griffin.suse.cz>
[not found] ` <20060216103543.5a96f0a0-IhiK2ZEFs2oCVLCxKZUutA@public.gmane.org>
2006-02-16 9:54 ` [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602152234.35463.mbuesch@freenet.de \
--to=mbuesch-kuij5kepwi6elga04laivw@public.gmane.org \
--cc=bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=jbenc-AlSwsSmVLrQ@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).