Re: [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module

Re: [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module

[Michael Buesch]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

On Wednesday 15 February 2006 20:21, you wrote:
> This patch fixes an oops when bcm43xx-d80211 module is unloaded.

This is already fixed in my tree.

> Signed-off-by: Jiri Benc <jbenc-AlSwsSmVLrQ@public.gmane.org>
> 
> --- dscape.testing.orig/drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c	2006-02-15 20:06:07.000000000 +0100
> +++ dscape.testing/drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c	2006-02-15 20:07:17.000000000 +0100
> @@ -4785,7 +4785,8 @@ static void __devexit bcm43xx_remove_one
>  	ieee80211_unregister_hw(net_dev);
>  	bcm43xx_detach_board(bcm);
>  	destroy_workqueue(bcm->workqueue);
> -	kfree_skb(bcm->cached_beacon);
> +	if (bcm->cached_beacon)
> +		kfree_skb(bcm->cached_beacon);
>  	assert(bcm->ucode == NULL);
>  	ieee80211_free_hw(net_dev);
>  	kfree(ieee);
> 
> 

-- 
Greetings Michael.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH wireless-2.6] bcm43xx-d80211: fix oops when removing the module

[Michael Buesch]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

On Thursday 16 February 2006 10:35, you wrote:
> On Wed, 15 Feb 2006 22:34:35 +0100, Michael Buesch wrote:
> > On Wednesday 15 February 2006 20:21, you wrote:
> > > This patch fixes an oops when bcm43xx-d80211 module is unloaded.
> > This is already fixed in my tree.
> 
> Is the tree available somewhere? I'm testing some patches for the d80211
> stack and it will help me if I can pull the latest bcm43xx version to my
> local repository.

sure.
git://bu3sch.de/wireless-2.6
branches dscape-all and softmac-all. The other branches are unused and
the result of the initial linville clone. ;) I should probably clean
it up a little bit, but I did not care, yet.

-- 
Greetings Michael.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]