From: Martin Michlmayr <tbm@cyrius.com>
To: netdev@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: Diff between Linus' and linux-mips git: declance
Date: Mon, 20 Feb 2006 14:22:33 +0000 [thread overview]
Message-ID: <20060220142233.GA3743@deprecation.cyrius.com> (raw)
In-Reply-To: <20060220001724.GB17967@deprecation.cyrius.com>
Updated patch, please apply.
[PATCH] Remove delta between Linus' and linux-mips git trees in declance
There are three changes between the Linus' and linux-mips git trees
regarding the declaner driver. The first change is certainly correct
(as it is consistent with the rest of the file) and should be applied
to mainline; the other change seems correct too. And the third is
cosmetic.
Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
---
--- a/drivers/net/declance.c 2006-02-03 03:07:02.000000000 +0000
+++ b/drivers/net/declance.c 2006-02-19 23:50:11.000000000 +0000
@@ -704,8 +704,8 @@
return IRQ_HANDLED;
}
-static irqreturn_t
-lance_interrupt(const int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t lance_interrupt(const int irq, void *dev_id,
+ struct pt_regs *regs)
{
struct net_device *dev = (struct net_device *) dev_id;
struct lance_private *lp = netdev_priv(dev);
@@ -1255,7 +1255,7 @@
return 0;
err_out_free_dev:
- kfree(dev);
+ free_netdev(dev);
err_out:
return ret;
@@ -1301,6 +1301,7 @@
while (root_lance_dev) {
struct net_device *dev = root_lance_dev;
struct lance_private *lp = netdev_priv(dev);
+
unregister_netdev(dev);
#ifdef CONFIG_TC
if (lp->slot >= 0)
--
Martin Michlmayr
http://www.cyrius.com/
next prev parent reply other threads:[~2006-02-20 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060219234318.GA16311@deprecation.cyrius.com>
[not found] ` <20060220000141.GX10266@deprecation.cyrius.com>
2006-02-20 0:17 ` Diff between Linus' and linux-mips git: declance Martin Michlmayr
2006-02-20 14:22 ` Martin Michlmayr [this message]
2006-02-20 17:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220142233.GA3743@deprecation.cyrius.com \
--to=tbm@cyrius.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).