From: Adrian Bunk <bunk@stusta.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Dipankar Sarma <dipankar@in.ibm.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, paulmck@us.ibm.com,
dada1@cosmosbay.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: [2.6 patch] make UNIX a bool
Date: Mon, 20 Feb 2006 23:36:06 +0100 [thread overview]
Message-ID: <20060220223606.GK4661@stusta.de> (raw)
In-Reply-To: <1140265890.4035.17.camel@laptopd505.fenrus.org>
On Sat, Feb 18, 2006 at 01:31:30PM +0100, Arjan van de Ven wrote:
> On Sat, 2006-02-18 at 12:14 +0000, Christoph Hellwig wrote:
> > > > - Make the get_max_files export use _GPL - only unix.ko uses it.
> >
> > The real question is, does af_unix really need to allow beeing built
> > modular? It's quite different from other network protocol and deeply
> > tied to the kernel due to things like descriptor passing or using
> > the filesystem namespace. I already had to export another symbol that
> > really should be internal just for it, and if one module acquires lots
> > of such hacks it's usually a bad sign..
>
> in 2.4 the answer would have been simple; modutils back then used
> AF_UNIX stuff before it could load modules, so modular was in practice
> impossible.
>
> Anyway I'd agree with making this non-modular... NOBODY will use this as
> a module, or if they do loading it somehow is the very first thing done.
> You just can't live without this, so making it a module is non-sensical.
So let's send a patch. ;-)
cu
Adrian
<-- snip -->
CONFIG_UNIX=m doesn't make much sense.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc4-mm1-full/net/unix/Kconfig.old 2006-02-20 14:40:19.000000000 +0100
+++ linux-2.6.16-rc4-mm1-full/net/unix/Kconfig 2006-02-20 14:40:27.000000000 +0100
@@ -3,7 +3,7 @@
#
config UNIX
- tristate "Unix domain sockets"
+ bool "Unix domain sockets"
---help---
If you say Y here, you will include support for Unix domain sockets;
sockets are the standard Unix mechanism for establishing and
next prev parent reply other threads:[~2006-02-20 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060217154147.GL29846@in.ibm.com>
[not found] ` <20060217154337.GM29846@in.ibm.com>
[not found] ` <20060217154626.GN29846@in.ibm.com>
[not found] ` <20060218010414.1f8d6782.akpm@osdl.org>
[not found] ` <20060218092517.GP29846@in.ibm.com>
2006-02-18 12:14 ` [PATCH 2/2] fix file counting Christoph Hellwig
2006-02-18 12:31 ` Arjan van de Ven
2006-02-20 22:36 ` Adrian Bunk [this message]
2006-02-25 16:01 [2.6 patch] make UNIX a bool Adrian Bunk
2006-02-25 17:13 ` Stephen Hemminger
2006-02-25 17:28 ` Arjan van de Ven
2006-02-26 18:19 ` Diego Calleja
2006-02-25 22:46 ` Olaf Hering
2006-03-25 19:47 ` Adrian Bunk
2006-03-26 15:20 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060220223606.GK4661@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=dipankar@in.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).