* [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static [not found] <20060224031002.0f7ff92a.akpm@osdl.org> @ 2006-02-25 13:27 ` Adrian Bunk 2006-02-25 14:31 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 2+ messages in thread From: Adrian Bunk @ 2006-02-25 13:27 UTC (permalink / raw) To: Andrew Morton, davem, acme; +Cc: linux-kernel, netdev On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote: >... > Changes since 2.6.16-rc4-mm1: >... > git-net.patch >... > git trees. >... There's no reason for struct dccp_v4_prot being global. Signed-off-by: Adrian Bunk <bunk@stusta.de> --- linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c.old 2006-02-25 04:32:45.000000000 +0100 +++ linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c 2006-02-25 04:32:53.000000000 +0100 @@ -1022,7 +1022,7 @@ .twsk_obj_size = sizeof(struct inet_timewait_sock), }; -struct proto dccp_v4_prot = { +static struct proto dccp_v4_prot = { .name = "DCCP", .owner = THIS_MODULE, .close = dccp_close, ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static 2006-02-25 13:27 ` [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static Adrian Bunk @ 2006-02-25 14:31 ` Arnaldo Carvalho de Melo 0 siblings, 0 replies; 2+ messages in thread From: Arnaldo Carvalho de Melo @ 2006-02-25 14:31 UTC (permalink / raw) To: Adrian Bunk; +Cc: Andrew Morton, davem, acme, linux-kernel, netdev On 2/25/06, Adrian Bunk <bunk@stusta.de> wrote: > On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote: > >... > > Changes since 2.6.16-rc4-mm1: > >... > > git-net.patch > >... > > git trees. > >... > > > There's no reason for struct dccp_v4_prot being global. > > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c.old 2006-02-25 04:32:45.000000000 +0100 > +++ linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c 2006-02-25 04:32:53.000000000 +0100 > @@ -1022,7 +1022,7 @@ > .twsk_obj_size = sizeof(struct inet_timewait_sock), > }; > > -struct proto dccp_v4_prot = { > +static struct proto dccp_v4_prot = { > .name = "DCCP", > .owner = THIS_MODULE, > .close = dccp_close, Heck, the last series of patches were exactly to separate ipv4/ipv6 in DCCP more clearly, how could I forget the cherry on top (sticking this static in front of dccp_v4_prot)? Eagle eyes indeed. Thanks. - Arnaldo ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-02-25 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060224031002.0f7ff92a.akpm@osdl.org>
2006-02-25 13:27 ` [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static Adrian Bunk
2006-02-25 14:31 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).