From: Wolfgang Hoffmann <woho@woho.de>
To: pomac@vapor.com
Cc: Stephen Hemminger <shemminger@osdl.org>,
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>,
Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, Pavel Volkovitskiy <int@mtx.ru>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert sky2 to 0.13a
Date: Sun, 26 Feb 2006 19:13:36 +0100 [thread overview]
Message-ID: <200602261913.36308.woho@woho.de> (raw)
In-Reply-To: <1140966011.22812.2.camel@localhost>
On Sunday 26 February 2006 16:00, Ian Kumlien wrote:
> On Sun, 2006-02-26 at 09:57 +0100, Wolfgang Hoffmann wrote:
> > Stephen, if you want me (as suggested off-list) to bisect the individual
> > patches leading from 0.13a to current head, please give me a series of
> > patches to incrementally apply, eighter via mail/ftp/git, and I'll test.
> > I don't want to hack the patches together myself, because results would
> > be worthless if I screw up, and given that I have no networking
> > background chances are high ...
>
> There is a git bisect for that, and a link for it somewhere =)
Ok, I did some reading and just started a git bisect. I didn't find hints on
how to bisect if I'm only interested in changes to sky2.[ch], so I'm taking
the full kernel tree and skip testing those bisect steps that didn't change
sky2.[ch].
Looking at Carl-Danies 0.13a and Stephens patch against 0.15 in this thread,
I'll patch each bisect step such that sky2_poll() has
sky2_write32(hw, STAT_CTRL, SC_STAT_CLR_IRQ);
if (sky2_read8(hw, STAT_LEV_TIMER_CTRL) == TIM_START) {
sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_STOP);
sky2_write8(hw, STAT_LEV_TIMER_CTRL, TIM_START);
}
after exit_loop. Is that ok?
I'll report as soon as I have results.
next prev parent reply other threads:[~2006-02-26 18:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 0:54 [PATCH] Revert sky2 to 0.13a Carl-Daniel Hailfinger
2006-02-26 2:03 ` Stephen Hemminger
2006-02-26 2:42 ` Ian Kumlien
2006-02-26 8:57 ` Wolfgang Hoffmann
2006-02-26 15:00 ` Ian Kumlien
2006-02-26 15:47 ` Arjan van de Ven
2006-02-26 16:13 ` Ian Kumlien
2006-02-26 22:38 ` Carl-Daniel Hailfinger
2006-02-27 0:43 ` Ian Kumlien
2006-02-27 18:50 ` Carl-Daniel Hailfinger
2006-02-26 18:13 ` Wolfgang Hoffmann [this message]
2006-02-26 22:31 ` Wolfgang Hoffmann
2006-02-26 23:03 ` Wolfgang Hoffmann
2006-02-27 16:00 ` Stephen Hemminger
2006-02-27 16:38 ` Wolfgang Hoffmann
2006-02-27 17:18 ` Stephen Hemminger
2006-02-27 17:48 ` Wolfgang Hoffmann
2006-02-27 18:27 ` Ian Kumlien
2006-02-27 18:38 ` Jeff Garzik
2006-02-26 15:28 ` Ian Kumlien
2006-02-26 2:25 ` Ian Kumlien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602261913.36308.woho@woho.de \
--to=woho@woho.de \
--cc=c-d.hailfinger.devel.2006@gmx.net \
--cc=int@mtx.ru \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pomac@vapor.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).