From: "David S. Miller" <davem@davemloft.net>
To: kaber@trash.net
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] [NETFILTER] ip_queue: Fix wrong skb->len == nlmsg_len assumption
Date: Tue, 07 Mar 2006 15:01:37 -0800 (PST) [thread overview]
Message-ID: <20060307.150137.63762785.davem@davemloft.net> (raw)
In-Reply-To: <440D838D.8000302@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Tue, 07 Mar 2006 13:58:53 +0100
> Thomas Graf wrote:
> > The size of the skb carrying the netlink message is not
> > equivalent to the length of the actual netlink message
> > due to padding. ip_queue matches the length of the payload
> > against the original packet size to determine if packet
> > mangling is desired, due to the above wrong assumption
> > arbitary packets may not be mangled depening on their
> > original size.
>
> Looks good, thanks Thomas. I think this should also go in 2.4.
Pushed to 2.6.16, 2.6.x stable, and 2.4.x.
Phew!
Thanks Thomas.
prev parent reply other threads:[~2006-03-07 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-07 12:31 [PATCH] [NETFILTER] ip_queue: Fix wrong skb->len == nlmsg_len assumption Thomas Graf
2006-03-07 12:58 ` Patrick McHardy
2006-03-07 23:01 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060307.150137.63762785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).