From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, rdreier@cisco.com,
linux-kernel@vger.kernel.org, openib-general@openib.org,
shemminger@osdl.org
Subject: Re: Re: TSO and IPoIB performance degradation
Date: Wed, 8 Mar 2006 14:53:11 +0200 [thread overview]
Message-ID: <20060308125311.GE17618@mellanox.co.il> (raw)
In-Reply-To: <20060307.172336.107863253.davem@davemloft.net>
Quoting r. David S. Miller <davem@davemloft.net>:
> Subject: Re: Re: TSO and IPoIB performance degradation
>
> From: Roland Dreier <rdreier@cisco.com>
> Date: Tue, 07 Mar 2006 17:17:30 -0800
>
> > The reason TSO comes up is that reverting the patch described below
> > helps (or helped at some point at least) IPoIB throughput quite a bit.
>
> I wish you had started the thread by mentioning this specific patch
Er, since you mention it, the first message in thread did include this link:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=314324121f9b94b2ca657a494cf2b9cb0e4a28cc
and I even pasted the patch description there, but oh well.
Now that Roland helped us clear it all up, and now that it has been clarified
that reverting this patch gives us back most of the performance, is the answer
to my question the same?
What I was trying to figure out was, how can we re-enable the trick without
hurting TSO? Could a solution be to simply look at the frame size, and call
tcp_send_delayed_ack if the frame size is small?
--
Michael S. Tsirkin
Staff Engineer, Mellanox Technologies
next prev parent reply other threads:[~2006-03-08 12:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 22:34 TSO and IPoIB performance degradation Michael S. Tsirkin
2006-03-06 22:40 ` David S. Miller
2006-03-06 22:50 ` Stephen Hemminger
2006-03-07 3:13 ` Shirley Ma
2006-03-07 21:44 ` Matt Leininger
2006-03-07 21:49 ` Stephen Hemminger
2006-03-07 21:53 ` Michael S. Tsirkin
2006-03-08 0:11 ` Matt Leininger
2006-03-08 0:18 ` David S. Miller
2006-03-08 1:17 ` Roland Dreier
2006-03-08 1:23 ` David S. Miller
2006-03-08 1:34 ` Roland Dreier
2006-03-08 12:53 ` Michael S. Tsirkin [this message]
2006-03-08 20:53 ` David S. Miller
2006-03-09 23:48 ` David S. Miller
2006-03-10 0:10 ` Michael S. Tsirkin
2006-03-10 0:38 ` Michael S. Tsirkin
2006-03-10 7:18 ` David S. Miller
2006-03-10 0:21 ` Rick Jones
2006-03-10 7:23 ` David S. Miller
2006-03-10 17:44 ` Rick Jones
2006-03-20 9:06 ` Michael S. Tsirkin
2006-03-20 9:55 ` David S. Miller
2006-03-20 10:22 ` Michael S. Tsirkin
2006-03-20 10:37 ` David S. Miller
2006-03-20 11:27 ` Michael S. Tsirkin
2006-03-20 11:47 ` Arjan van de Ven
2006-03-20 11:49 ` Lennert Buytenhek
2006-03-20 11:53 ` Arjan van de Ven
2006-03-20 13:35 ` Michael S. Tsirkin
2006-03-20 12:04 ` Michael S. Tsirkin
2006-03-20 15:09 ` Benjamin LaHaise
2006-03-20 18:58 ` Rick Jones
2006-03-20 23:00 ` David S. Miller
2006-04-27 4:13 ` Troy Benjegerdes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060308125311.GE17618@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).