* [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun
@ 2006-03-11 3:42 Adrian Bunk
2006-03-14 3:05 ` Zhu Yi
2006-03-18 1:13 ` John W. Linville
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-03-11 3:42 UTC (permalink / raw)
To: yi.zhu, jketreno; +Cc: netdev, linville, linux-kernel
This patch fixes a big array overun found by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c.old 2006-03-11 02:41:23.000000000 +0100
+++ linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c 2006-03-11 02:42:04.000000000 +0100
@@ -9956,9 +9956,8 @@ static int ipw_ethtool_set_eeprom(struct
return -EINVAL;
mutex_lock(&p->mutex);
memcpy(&p->eeprom[eeprom->offset], bytes, eeprom->len);
- for (i = IPW_EEPROM_DATA;
- i < IPW_EEPROM_DATA + IPW_EEPROM_IMAGE_SIZE; i++)
- ipw_write8(p, i, p->eeprom[i]);
+ for (i = 0; i < IPW_EEPROM_IMAGE_SIZE; i++)
+ ipw_write8(p, i + IPW_EEPROM_DATA, p->eeprom[i]);
mutex_unlock(&p->mutex);
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun
2006-03-11 3:42 [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun Adrian Bunk
@ 2006-03-14 3:05 ` Zhu Yi
2006-03-18 1:13 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: Zhu Yi @ 2006-03-14 3:05 UTC (permalink / raw)
To: Adrian Bunk; +Cc: jketreno, netdev, linville, linux-kernel
On Sat, 2006-03-11 at 04:42 +0100, Adrian Bunk wrote:
> This patch fixes a big array overun found by the Coverity checker.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c.old 2006-03-11 02:41:23.000000000 +0100
> +++ linux-2.6.16-rc5-mm3-full/drivers/net/wireless/ipw2200.c 2006-03-11 02:42:04.000000000 +0100
> @@ -9956,9 +9956,8 @@ static int ipw_ethtool_set_eeprom(struct
> return -EINVAL;
> mutex_lock(&p->mutex);
> memcpy(&p->eeprom[eeprom->offset], bytes, eeprom->len);
> - for (i = IPW_EEPROM_DATA;
> - i < IPW_EEPROM_DATA + IPW_EEPROM_IMAGE_SIZE; i++)
> - ipw_write8(p, i, p->eeprom[i]);
> + for (i = 0; i < IPW_EEPROM_IMAGE_SIZE; i++)
> + ipw_write8(p, i + IPW_EEPROM_DATA, p->eeprom[i]);
> mutex_unlock(&p->mutex);
> return 0;
> }
Acked-by: Zhu Yi <yi.zhu@intel.com>
Thanks,
-yi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun
2006-03-11 3:42 [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun Adrian Bunk
2006-03-14 3:05 ` Zhu Yi
@ 2006-03-18 1:13 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2006-03-18 1:13 UTC (permalink / raw)
To: Adrian Bunk; +Cc: yi.zhu, jketreno, netdev, linux-kernel
On Sat, Mar 11, 2006 at 04:42:58AM +0100, Adrian Bunk wrote:
> This patch fixes a big array overun found by the Coverity checker.
Merged to upstream branch of wireless-2.6...thanks!
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-03-18 1:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-11 3:42 [2.6 patch] drivers/net/wireless/ipw2200.c: fix an array overun Adrian Bunk
2006-03-14 3:05 ` Zhu Yi
2006-03-18 1:13 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).