From: Jouni Malinen <jkmaline@cc.hut.fi>
To: Adrian Bunk <bunk@stusta.de>
Cc: netdev@vger.kernel.org, hostap@shmoo.com,
linux-kernel@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [RFC: 2.6 patch] hostap_hw.c:hfa384x_set_rid(): fix error handling
Date: Sun, 12 Mar 2006 17:15:38 -0800 [thread overview]
Message-ID: <20060313011538.GU9383@jm.kir.nu> (raw)
In-Reply-To: <20060309230646.GI21864@stusta.de>
On Fri, Mar 10, 2006 at 12:06:46AM +0100, Adrian Bunk wrote:
> The Coverity checker noted that the call to prism2_hw_reset() was dead
> code.
>
> Does this patch change the code to what was intended?
Thanks! Based on my CVS history, it looks like this was broken in 2002
when the access command was moved from another function and verification
of -ETIMEDOUT value was not moved correctly. The original behavior would
be achieved by changing your patch to call printk first before the moved
prism2_hw_reset(dev) call. I added this (with the re-ordered printk) to
my queue for wireless-2.6.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2006-03-13 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 23:06 [RFC: 2.6 patch] hostap_hw.c:hfa384x_set_rid(): fix error handling Adrian Bunk
2006-03-13 1:15 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313011538.GU9383@jm.kir.nu \
--to=jkmaline@cc.hut.fi \
--cc=bunk@stusta.de \
--cc=hostap@shmoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).