From: thockin@hockin.org
To: Jeff Garzik <jgarzik@pobox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/4] natsemi: Add support for using MII port with no PHY
Date: Mon, 13 Mar 2006 10:41:29 -0800 [thread overview]
Message-ID: <20060313184129.GA23984@hockin.org> (raw)
In-Reply-To: <20060313182331.GA19014@sirena.org.uk>
On Mon, Mar 13, 2006 at 06:23:31PM +0000, Mark Brown wrote:
> On Sun, Mar 12, 2006 at 01:41:13PM -0800, thockin@hockin.org wrote:
>
> > Not that my opinion should hold much weight, having been absent from the
> > driver for some time, but yuck. Is there no better way to do this thatn
> > sprinkling poo all over it?
>
> The changes are mostly isolated into check_link(), the fact that half
> the function gets placed inside a conditional but diff sees it as a
> bunch of smaller changes makes the changes look a lot more invasive than
> they actually are. I guess that could be helped by splitting the PHY
> access code out of check_link() into check_phy_status() or something but
> I'm not sure how much that really helps.
It's not terribly offensive it just seems like a hack. :) I'm not sure I
really understand the reasoning, so I can't offer anythign better or more
general purpose.
next prev parent reply other threads:[~2006-03-13 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 19:22 [patch 0/4] natsemi: Aculab E1/T1 PMXc Carrier Card support Mark Brown
2006-03-12 19:23 ` [patch 1/4] natsemi: Add support for using MII port with no PHY Mark Brown
2006-03-12 21:41 ` thockin
2006-03-13 18:23 ` Mark Brown
2006-03-13 18:41 ` thockin [this message]
2006-03-16 9:09 ` Andrew Morton
2006-03-16 9:26 ` Mark Brown
2006-03-12 19:23 ` [patch 2/4] natsemi: Support oversized EEPROMs Mark Brown
2006-03-12 19:23 ` [patch 3/4] Add a PCI vendor ID definition for Aculab Mark Brown
2006-03-12 19:23 ` [patch 4/4] natsemi: Add quirks for Aculab E1/T1 PMXc cPCI carrier cards Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313184129.GA23984@hockin.org \
--to=thockin@hockin.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).