From mboxrd@z Thu Jan 1 00:00:00 1970 From: thockin@hockin.org Subject: Re: [patch 1/4] natsemi: Add support for using MII port with no PHY Date: Mon, 13 Mar 2006 10:41:29 -0800 Message-ID: <20060313184129.GA23984@hockin.org> References: <20060312192259.929734000@mercator.sirena.org.uk> <20060312205303.869316000@mercator.sirena.org.uk> <20060312214113.GA15071@hockin.org> <20060313182331.GA19014@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: To: Jeff Garzik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Disposition: inline In-Reply-To: <20060313182331.GA19014@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Mar 13, 2006 at 06:23:31PM +0000, Mark Brown wrote: > On Sun, Mar 12, 2006 at 01:41:13PM -0800, thockin@hockin.org wrote: > > > Not that my opinion should hold much weight, having been absent from the > > driver for some time, but yuck. Is there no better way to do this thatn > > sprinkling poo all over it? > > The changes are mostly isolated into check_link(), the fact that half > the function gets placed inside a conditional but diff sees it as a > bunch of smaller changes makes the changes look a lot more invasive than > they actually are. I guess that could be helped by splitting the PHY > access code out of check_link() into check_phy_status() or something but > I'm not sure how much that really helps. It's not terribly offensive it just seems like a hack. :) I'm not sure I really understand the reasoning, so I can't offer anythign better or more general purpose.