* Re: 2.6.16-rc6-mm1
[not found] <20060312031036.3a382581.akpm@osdl.org>
@ 2006-03-12 15:55 ` Benoit Boissinot
2006-03-13 21:26 ` [-mm patch] make drivers/net/tg3.c:tg3_request_irq() Adrian Bunk
1 sibling, 0 replies; 3+ messages in thread
From: Benoit Boissinot @ 2006-03-12 15:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, jgarzik, netdev
On Sun, Mar 12, 2006 at 03:10:36AM -0800, Andrew Morton wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc6/2.6.16-rc6-mm1/
>
>
drivers/net/tg3.c:8065: warning: type qualifiers ignored on function return type
Signed-off-by: Benoit Boissinot <benoit.boissinot@ens-lyon.fr>
Index: linux/drivers/net/tg3.c
===================================================================
--- linux.orig/drivers/net/tg3.c
+++ linux/drivers/net/tg3.c
@@ -8061,7 +8061,7 @@ static int tg3_test_link(struct tg3 *tp)
}
/* Only test the commonly used registers */
-static const int tg3_test_registers(struct tg3 *tp)
+static int tg3_test_registers(struct tg3 *tp)
{
int i, is_5705;
u32 offset, read_mask, write_mask, val, save_val, read_val;
--
powered by bash/screen/(urxvt/fvwm|linux-console)/gentoo/gnu/linux OS
^ permalink raw reply [flat|nested] 3+ messages in thread* [-mm patch] make drivers/net/tg3.c:tg3_request_irq()
[not found] <20060312031036.3a382581.akpm@osdl.org>
2006-03-12 15:55 ` 2.6.16-rc6-mm1 Benoit Boissinot
@ 2006-03-13 21:26 ` Adrian Bunk
2006-03-15 1:04 ` David S. Miller
1 sibling, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-03-13 21:26 UTC (permalink / raw)
To: Andrew Morton, davem; +Cc: linux-kernel, netdev, jgarzik
On Sun, Mar 12, 2006 at 03:10:36AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc5-mm3:
>...
> git-net.patch
>...
> git trees
>...
This patch makes the needlessly global function tg3_request_irq()
static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc6-mm1-full/drivers/net/tg3.c.old 2006-03-13 21:13:31.000000000 +0100
+++ linux-2.6.16-rc6-mm1-full/drivers/net/tg3.c 2006-03-13 21:14:26.000000000 +0100
@@ -6531,7 +6531,7 @@
add_timer(&tp->timer);
}
-int tg3_request_irq(struct tg3 *tp)
+static int tg3_request_irq(struct tg3 *tp)
{
irqreturn_t (*fn)(int, void *, struct pt_regs *);
unsigned long flags;
^ permalink raw reply [flat|nested] 3+ messages in thread