From: Chris Wright <chrisw@sous-sol.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: chrisw@sous-sol.org, cxzhang@watson.ibm.com, netdev@axxeo.de,
ioe-lkml@rameria.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] scm: fold __scm_send() into scm_send()
Date: Mon, 20 Mar 2006 15:43:38 -0800 [thread overview]
Message-ID: <20060320234338.GW15997@sorel.sous-sol.org> (raw)
In-Reply-To: <20060320.152838.68858441.davem@davemloft.net>
* David S. Miller (davem@davemloft.net) wrote:
> From: Chris Wright <chrisw@sous-sol.org>
> Date: Mon, 20 Mar 2006 13:36:36 -0800
>
> > The point of Catherine's original patch was to make sure there's always
> > a security identifier associated with AF_UNIX messages. So receiver
> > can always check it (same as having credentials even w/out sender
> > control message passing them). Now we will have garbage for sid.
>
> I'm seriously considering backing out Catherine's AF_UNIX patch from
> the net-2.6.17 tree before submitting it to Linus later today so that
> none of this crap goes in right now.
>
> It appears that this needs a lot more sorting out, so for now that's
> probably the right thing to do.
I won't object. I checked your tree, it looks OK to me. The actual
broken patch appears in -mm, and the security_sid_to_context snafu
is primarily cosmetic at this point (the exports, etc fixed the real
compilation issues AFAICT). But, again, if you want to drop that's fine
w/ me. I'm sure Catherine can cleanup and resend as needed.
thanks,
-chris
next prev parent reply other threads:[~2006-03-20 23:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200603130139.k2D1dpSQ021279@shell0.pdx.osdl.net>
[not found] ` <20060312.180802.13404061.davem@davemloft.net>
2006-03-13 20:05 ` [PATCH] scm: fold __scm_send() into scm_send() Ingo Oeser
2006-03-13 20:22 ` Benjamin LaHaise
2006-03-13 22:13 ` Andrew Morton
2006-03-14 1:31 ` Andrew Morton
2006-03-20 11:44 ` Ingo Oeser
2006-03-20 20:18 ` Chris Wright
2006-03-20 21:36 ` Chris Wright
2006-03-20 22:31 ` Andrew Morton
2006-03-20 23:15 ` Chris Wright
2006-03-21 13:32 ` Stephen Smalley
2006-03-21 13:42 ` Stephen Smalley
2006-04-06 17:52 ` Xiaolan Zhang
2006-03-20 23:28 ` David S. Miller
2006-03-20 23:43 ` Chris Wright [this message]
2006-03-21 0:37 ` James Morris
2006-03-21 0:50 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060320234338.GW15997@sorel.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=akpm@osdl.org \
--cc=cxzhang@watson.ibm.com \
--cc=davem@davemloft.net \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@axxeo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).