From: Stephen Hemminger <shemminger@osdl.org>
To: James Lentini <jlentini@netapp.com>
Cc: netdev@vger.kernel.org,
openib-general <openib-general@openib.org>,
lartc@mailman.ds9a.nl
Subject: Re: [iproute2] IPoIB link layer address bug
Date: Tue, 21 Mar 2006 15:56:17 -0800 [thread overview]
Message-ID: <20060321155617.3ae419b2@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.61.0603161707360.23670@jlentini-linux.nane.netapp.com>
On Thu, 16 Mar 2006 17:24:41 -0500 (EST)
James Lentini <jlentini@netapp.com> wrote:
>
> The ip(8) command has a bug when dealing with IPoIB link layer
> addresses. Specifically it does not correctly handle the addition of
> new entries in the neighbor/arp table. For example, this command will
> fail:
>
> ip neigh add 192.168.0.138 lladdr 00:00:04:04:fe:80:00:00:00:00:00:00:00:01:73:00:00:00:8a:91 nud permanent dev ib0
>
> An IPoIB link layer address is 20-bytes (see
> http://www.ietf.org/internet-drafts/draft-ietf-ipoib-ip-over-infiniband-09.txt,
> section 9.1.1).
>
> The command line parsing code expects link layer addresses to be a
> maximum of 16-bytes. Addresses over 16-bytes are truncated.
>
> This patch (against the iproute2 cvs repository) fixes the problem:
>
Okay, but there are number of other places in iproute2 that call ll_addr_a2n()
with ifr.ifr_hwaddr.sa_data. And that is 14 bytes. If you want to fix those
it will be harder since it would increase the sizeof(struct sockaddr) and potentially
break compatibility.
next prev parent reply other threads:[~2006-03-21 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 22:24 [iproute2] IPoIB link layer address bug James Lentini
2006-03-21 23:56 ` Stephen Hemminger [this message]
2006-03-22 1:30 ` Jason Gunthorpe
2006-03-23 17:12 ` James Lentini
2006-03-23 18:10 ` Mark Butler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060321155617.3ae419b2@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=jlentini@netapp.com \
--cc=lartc@mailman.ds9a.nl \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).