From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org,
openib-general <openib-general@openib.org>,
lartc@mailman.ds9a.nl
Subject: Re: Re: [iproute2] IPoIB link layer address bug
Date: Tue, 21 Mar 2006 18:30:46 -0700 [thread overview]
Message-ID: <20060322013046.GA29127@obsidianresearch.com> (raw)
In-Reply-To: <20060321155617.3ae419b2@localhost.localdomain>
On Tue, Mar 21, 2006 at 03:56:17PM -0800, Stephen Hemminger wrote:
> Okay, but there are number of other places in iproute2 that call ll_addr_a2n()
> with ifr.ifr_hwaddr.sa_data. And that is 14 bytes. If you want to fix those
> it will be harder since it would increase the sizeof(struct sockaddr) and potentially
> break compatibility.
Maybe the best thing is to upgrade ip (and or netlink?) to use netlink
messages instead of ioctls for the remaining problematic operations.
Since netlink already supports an arbitary length hwaddr there should
be no compatability problem.
Just browsing I see usages of SIOCSIFHWBROADCAST, SIOCSIFHWADDR,
SIOCADDMULTI, SIOCDELMULTI and SIOCGIFHWADDR that use a struct ifreq..
I know SIOCGIFHWADDR can be done over netlink, but I'm not too
familiar with the others..
Jason
next prev parent reply other threads:[~2006-03-22 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-16 22:24 [iproute2] IPoIB link layer address bug James Lentini
2006-03-21 23:56 ` Stephen Hemminger
2006-03-22 1:30 ` Jason Gunthorpe [this message]
2006-03-23 17:12 ` James Lentini
2006-03-23 18:10 ` Mark Butler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060322013046.GA29127@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=lartc@mailman.ds9a.nl \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).