From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: Re: [iproute2] IPoIB link layer address bug Date: Tue, 21 Mar 2006 18:30:46 -0700 Message-ID: <20060322013046.GA29127@obsidianresearch.com> References: <20060321155617.3ae419b2@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, openib-general , lartc@mailman.ds9a.nl Return-path: To: Stephen Hemminger Content-Disposition: inline In-Reply-To: <20060321155617.3ae419b2@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openib-general-bounces@openib.org Errors-To: openib-general-bounces@openib.org List-Id: netdev.vger.kernel.org On Tue, Mar 21, 2006 at 03:56:17PM -0800, Stephen Hemminger wrote: > Okay, but there are number of other places in iproute2 that call ll_addr_a2n() > with ifr.ifr_hwaddr.sa_data. And that is 14 bytes. If you want to fix those > it will be harder since it would increase the sizeof(struct sockaddr) and potentially > break compatibility. Maybe the best thing is to upgrade ip (and or netlink?) to use netlink messages instead of ioctls for the remaining problematic operations. Since netlink already supports an arbitary length hwaddr there should be no compatability problem. Just browsing I see usages of SIOCSIFHWBROADCAST, SIOCSIFHWADDR, SIOCADDMULTI, SIOCDELMULTI and SIOCGIFHWADDR that use a struct ifreq.. I know SIOCGIFHWADDR can be done over netlink, but I'm not too familiar with the others.. Jason