From: Adrian Bunk <bunk@stusta.de>
To: Jing Min Zhao <zhaojignmin@hotmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr() static
Date: Fri, 24 Mar 2006 01:09:16 +0100 [thread overview]
Message-ID: <20060324000916.GN22727@stusta.de> (raw)
This patch makes a needlessly global function static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
net/ipv4/netfilter/ip_conntrack_helper_h323.c | 5 ++---
net/ipv4/netfilter/ip_nat_helper_h323.c | 2 --
2 files changed, 2 insertions(+), 5 deletions(-)
--- linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_nat_helper_h323.c.old 2006-03-23 23:13:59.000000000 +0100
+++ linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_nat_helper_h323.c 2006-03-23 23:14:05.000000000 +0100
@@ -49,8 +49,6 @@
#define DEBUGP(format, args...)
#endif
-extern int get_h245_addr(unsigned char *data, H245_TransportAddress * addr,
- u_int32_t * ip, u_int16_t * port);
extern int get_h225_addr(unsigned char *data, TransportAddress * addr,
u_int32_t * ip, u_int16_t * port);
extern void ip_conntrack_h245_expect(struct ip_conntrack *new,
--- linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_conntrack_helper_h323.c.old 2006-03-23 23:14:21.000000000 +0100
+++ linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_conntrack_helper_h323.c 2006-03-23 23:14:35.000000000 +0100
@@ -222,8 +222,8 @@
}
/****************************************************************************/
-int get_h245_addr(unsigned char *data, H245_TransportAddress * addr,
- u_int32_t * ip, u_int16_t * port)
+static int get_h245_addr(unsigned char *data, H245_TransportAddress * addr,
+ u_int32_t * ip, u_int16_t * port)
{
unsigned char *p;
@@ -1713,7 +1713,6 @@
module_init(init);
module_exit(fini);
-EXPORT_SYMBOL(get_h245_addr);
EXPORT_SYMBOL(get_h225_addr);
EXPORT_SYMBOL(ip_conntrack_h245_expect);
EXPORT_SYMBOL(ip_conntrack_q931_expect);
next reply other threads:[~2006-03-24 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 0:09 Adrian Bunk [this message]
2006-03-24 2:37 ` 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static Jing Min Zhao
2006-03-24 7:55 ` Adrian Bunk
2006-03-24 7:55 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324000916.GN22727@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=zhaojignmin@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).