From: Adrian Bunk <bunk@stusta.de>
To: Jing Min Zhao <zhaojingmin@hotmail.com>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
Jing Min Zhao <zhaojignmin@hotmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static
Date: Fri, 24 Mar 2006 08:55:11 +0100 [thread overview]
Message-ID: <20060324075511.GV22727@stusta.de> (raw)
In-Reply-To: <BAY109-DAV122F44146DB217251703AEB3DF0@phx.gbl>
On Thu, Mar 23, 2006 at 09:37:15PM -0500, Jing Min Zhao wrote:
>
> I'd like to keep it global. In the future we may need it.
The point is:
There have been many occasions where people have said "I will need this
soon" in many different places in the kernel, and one year later it was
still unused.
If it will be needed at some point in the future, reverting my patch
will be trivial.
> Thanks
>
> Jing Min Zhao
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2006-03-24 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 0:09 [RFC: 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr() static Adrian Bunk
2006-03-24 2:37 ` 2.6 patch] ip_conntrack_helper_h323.c: make get_h245_addr()static Jing Min Zhao
2006-03-24 7:55 ` Adrian Bunk [this message]
2006-03-24 7:55 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324075511.GV22727@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=zhaojignmin@hotmail.com \
--cc=zhaojingmin@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).