From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Norbert Kiesel <nkiesel@tbdnetworks.com>,
acme@conectiva.com.br, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: [2.6 patch] net: drop duplicate assignment in request_sock
Date: Sun, 26 Mar 2006 14:24:10 +0200 [thread overview]
Message-ID: <20060326122410.GG4053@stusta.de> (raw)
From: Norbert Kiesel <nkiesel@tbdnetworks.com>
Just noticed that request_sock.[ch] contain a useless assignment of
rskq_accept_head to itself. I assume this is a typo and the 2nd one
was supposed to be _tail. However, setting _tail to NULL is not
needed, so the patch below just drops the 2nd assignment.
Signed-Off-By: Norbert Kiesel <nkiesel@tbdnetworks.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was sent by Norbert Kiesel on:
- 5 Mar 2006
diff -ru a/include/net/request_sock.h b/include/net/request_sock.h
--- a/include/net/request_sock.h 2005-10-28 15:44:45.000000000 -0700
+++ b/include/net/request_sock.h 2006-03-05 15:22:33.000000000 -0800
@@ -145,7 +145,7 @@
{
struct request_sock *req = queue->rskq_accept_head;
- queue->rskq_accept_head = queue->rskq_accept_head = NULL;
+ queue->rskq_accept_head = NULL;
return req;
}
diff -ru a/net/core/request_sock.c b/net/core/request_sock.c
--- a/net/core/request_sock.c 2006-03-05 14:40:50.000000000 -0800
+++ b/net/core/request_sock.c 2006-03-05 15:23:11.000000000 -0800
@@ -51,7 +51,7 @@
get_random_bytes(&lopt->hash_rnd, sizeof(lopt->hash_rnd));
rwlock_init(&queue->syn_wait_lock);
- queue->rskq_accept_head = queue->rskq_accept_head = NULL;
+ queue->rskq_accept_head = NULL;
lopt->nr_table_entries = nr_table_entries;
write_lock_bh(&queue->syn_wait_lock);
next reply other threads:[~2006-03-26 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-26 12:24 Adrian Bunk [this message]
2006-03-27 1:39 ` [2.6 patch] net: drop duplicate assignment in request_sock David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060326122410.GG4053@stusta.de \
--to=bunk@stusta.de \
--cc=acme@conectiva.com.br \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nkiesel@tbdnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).