From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David S. Miller" Subject: Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed... Date: Fri, 31 Mar 2006 01:13:24 -0800 (PST) Message-ID: <20060331.011324.87942482.davem@davemloft.net> References: <20060329.204409.109404254.davem@davemloft.net> <20060330095245.GA2385@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jesse.brandeburg@intel.com, nipsy@bitgnome.net, jrlundgren@gmail.com, cat@zip.com.au, djani22@dynamicweb.hu, yoseph.basri@gmail.com, bb@kernelpanic.ru, mykleb@no.ibm.com, olel@ans.pl, michal@feix.cz, chris@scorpion.nl, netdev@vger.kernel.org, jesse.brandeburg@gmail.com, E1000-devel@lists.sourceforge.net Return-path: To: herbert@gondor.apana.org.au In-Reply-To: <20060330095245.GA2385@gondor.apana.org.au> Sender: e1000-devel-admin@lists.sourceforge.net Errors-To: e1000-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org From: Herbert Xu Date: Thu, 30 Mar 2006 20:52:45 +1100 > Well I started from the beginning again, and found this. This may be > the smoking gun that we're after :) > > The xmit routine is lockless but checks last_tx_tso outside the locked > section. So if a TSO packet wins a race against a non-TSO packet with > last_tx_tso == 0 then we'll have memory corruption. Regardless of whether this fixes the bug being discussed, this fix should go into the e1000 driver ASAP. Good spotting Herbert. ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642