netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...
@ 2006-03-30  2:53 Brandeburg, Jesse
  2006-03-30  4:02 ` Yoseph Basri
                   ` (8 more replies)
  0 siblings, 9 replies; 62+ messages in thread
From: Brandeburg, Jesse @ 2006-03-30  2:53 UTC (permalink / raw)
  To: nipsy, jrlundgren, cat, djani22, yoseph.basri, bb, mykleb, olel,
	michal, chris
  Cc: netdev, Jesse Brandeburg, davem, E1000-devel, Brandeburg, Jesse

Hi all, I've identified you as people who have at some point in the past
emailed one of the Linux lists with problems with e1000 and
sk_forward_alloc.  It seems to be fairly widespread, but only seems to
have appeared with recent kernel changes (after 2.6.12...)

What I need from you is a reproducible test, and some information.  I
have never been able to reproduce this, and I'm trying to isolate the
problem a bit.  What motherboards are you using?  What seems to cause
this problem?  Are you all using iptables?  Are you all routing? From
the reports I assume none of you are using an 82571/2/3 (pci express)

As far as I know e1000 has the same requirement as tg3 and some others
where we have to modify the header of the skb in the case of transmits
using TSO.  I don't see anywhere else that the driver modifies the skb.
Tomorrow I'll generate a patch to try a more paranoid copying of the
skb, I hope some of you can test.

To do this we have code like so in e1000_tso:
2529         if (skb_shinfo(skb)->tso_size) {
2530                 if (skb_header_cloned(skb)) {
2531                         err = pskb_expand_head(skb, 0, 0,
GFP_ATOMIC);
2532                         if (err)
2533                                 return err;
2534                 }
2535 
2536                 hdr_len = ((skb->h.raw - skb->data) +
(skb->h.th->doff << 2));
2537                 mss = skb_shinfo(skb)->tso_size;
2538                 if (skb->protocol == ntohs(ETH_P_IP)) {
2539                         skb->nh.iph->tot_len = 0;
2540                         skb->nh.iph->check = 0;

Thanks for your assistance

Jesse


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642

^ permalink raw reply	[flat|nested] 62+ messages in thread

end of thread, other threads:[~2006-04-14 23:57 UTC | newest]

Thread overview: 62+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-30  2:53 [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed Brandeburg, Jesse
2006-03-30  4:02 ` Yoseph Basri
2006-03-30  4:25 ` Phil Oester
2006-03-30  4:44 ` David S. Miller
2006-03-30  9:52   ` Herbert Xu
2006-03-30 10:02     ` Boris B. Zhmurov
2006-03-30 10:12       ` Herbert Xu
2006-03-30 12:53         ` JaniD++
2006-03-30 13:29         ` Boris B. Zhmurov
2006-03-31  9:12           ` David S. Miller
2006-03-31 10:16             ` Boris B. Zhmurov
2006-03-31 10:39               ` Herbert Xu
2006-03-31 10:45                 ` David S. Miller
2006-03-31 10:51                   ` Boris B. Zhmurov
2006-03-31 10:52                     ` Herbert Xu
2006-03-31 11:02                       ` Boris B. Zhmurov
2006-03-31 12:07                 ` Boris B. Zhmurov
2006-03-31 11:15                   ` Andi Kleen
2006-03-31 12:10                   ` Mark Nipper
2006-03-31 12:23                     ` Boris B. Zhmurov
2006-03-31 12:35                       ` Herbert Xu
2006-03-31 12:36                         ` Boris B. Zhmurov
2006-04-03 21:01                         ` Mark Nipper
2006-04-03 21:39                           ` Phil Oester
2006-04-03 22:00                             ` Boris B. Zhmurov
2006-04-05 22:05                               ` Jesse Brandeburg
2006-04-06  0:42                                 ` Jesse Brandeburg
2006-04-06 11:49                                   ` Boris B. Zhmurov
2006-04-14 20:28                                     ` Jesse Brandeburg
2006-04-14 21:02                                       ` David S. Miller
2006-04-14 22:32                                         ` Jesse Brandeburg
2006-04-14 22:42                                           ` David S. Miller
2006-04-14 22:46                                             ` Jesse Brandeburg
2006-04-14 22:52                                               ` David S. Miller
2006-04-14 22:55                                                 ` Jesse Brandeburg
2006-04-14 23:53                                                   ` David S. Miller
2006-03-31 12:46                       ` Boris B. Zhmurov
2006-03-31 13:12                         ` Christiaan den Besten
2006-03-31 13:30                           ` Boris B. Zhmurov
2006-03-31 15:08                             ` Boris B. Zhmurov
2006-03-31 15:19                               ` Boris B. Zhmurov
2006-03-31 16:01                                 ` Mark Nipper
2006-03-31 17:19                                   ` Boris B. Zhmurov
2006-03-31 12:45                   ` JaniD++
2006-03-31  9:13     ` David S. Miller
2006-03-30  8:08 ` Christiaan den Besten
2006-03-30  8:24 ` Mark Nipper
2006-03-30 10:29   ` Krzysztof Oledzki
2006-03-30 16:22   ` Phil Oester
2006-03-30 17:21     ` Krzysztof Oledzki
2006-03-30  8:39 ` Boris B. Zhmurov
2006-03-30  9:49 ` Johan Lundgren
2006-03-30 10:27 ` Krzysztof Oledzki
2006-03-31  8:57 ` Ingo Oeser
2006-03-31  9:12   ` David S. Miller
2006-03-31  9:16   ` Herbert Xu
2006-03-31  9:35     ` David S. Miller
2006-03-31  9:42       ` Herbert Xu
2006-03-31 12:02         ` JaniD++
2006-03-31 12:18         ` Ingo Oeser
2006-03-31 17:22           ` Jesse Brandeburg
2006-03-31 10:51       ` Mark Nipper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).