From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Roskin Subject: Re: [PATCH 17/21] orinoco_pci: use pci_iomap() for resources Date: Fri, 7 Apr 2006 20:07:31 -0400 Message-ID: <20060407200731.mqskowo8808gccs8@webmail.spamcop.net> References: <20060407081019.16107.67672.stgit@dv.roinet.com> <20060407081053.16107.19347.stgit@dv.roinet.com> <20060407213619.GB15720@electric-eye.fr.zoreil.com> <1144448517.5618.14.camel@dv> <20060407233819.GB15667@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: jgarzik-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, orinoco-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: To: Francois Romieu In-Reply-To: <20060407233819.GB15667-lmTtMILVy1jWQcoT9B9Ug5SCg42XY1Uw0E9HWUfgJXw@public.gmane.org> Content-Disposition: inline Sender: orinoco-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: orinoco-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org Quoting Francois Romieu : > > > Is there a reason why dev->mem_{start/end} should not be removed ? > > > > Is there a reason why it should? Is it going to be obsolete? > > It is slowly obsoleting for a few years (don't laugh...). It is preferred > to store the relevant address in the private part of the (pci) device. > > Moderately recent drivers do not use it at all. However it's fairly common > in the setup code of the (legacy) isa devices. I agree that many drivers don't use it. But it would be nice to have a document describing what is going on. On one hand we are adding new information elements (such as the bus in "ethtool -i"), on the other hand we are removing addresses from the ifconfig output. Who is deciding which information is useful and which is not? How about netdev->irq? Is it going to be obsolete too? Then I can easily remove orinoco_pci_setup_netdev() with very minimal adjustments. -- Regards, Pavel Roskin ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642